Repository navigation
test: add portable three-shard free-requested interop fixture - #256
Merged
Merged
Conversation
Owner
Author
检视结论:approve对照 #249 / msinsight #625(生产侧):3 片 fixture + CLI 导入; 可独立于 runner 扩展 PR 提前合入。本评论不 approve/merge。 |
This was referenced Oct 11, 2026
codeasier
marked this pull request as ready for review
October 11, 2026 16:05
codeasier
commented
Oct 11, 2026
codeasier
left a comment
Owner
Author
There was a problem hiding this comment.
LGTM,已转为正式 PR。GitHub 不允许作者账号提交 APPROVE,以本评论 + 此前检视评论作为通过记录。可独立提前合入。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refs #249. Related to #248 and msinsight #625; this does not fix, execute or verify the consumer.
Testing
PYTHONPATH="$PWD/src" python -m pytest tests/test_fixture_provenance.py tests/test_interop_three_shard.py tests/core/test_msinsight_export.py tests/snapshot/test_sharded_replay.py tests/test_native_dataset.py tests/test_interop_acceptance.py tests/test_governance.pyruff check .black --check .(237 files unchanged)python -m basedpyright --pythonpath <intended interpreter>: 0 errors; 1,745 existing warnings.git diff --checkand relative documentation-link checks.Provenance and limits
Snapshot provenance decision: no-update
Snapshot provenance no-update reason: No files under src/pt_snap_cli/snapshot are changed; this adds independently authored tests, synthetic fixture data and docs. Fixture-specific provenance is recorded separately under tests/fixtures/interop/PROVENANCE.md.
Reproduction is semantic across supported Python/SQLite versions, not a claim of byte-identical artifacts: the committed fixture retains real generation timestamps/version/source metadata and its recorded hashes. Use a freshly generated original pickle adjacent to its generated .msinsight cache for any separately authorized GUI retest; do not let a mutating consumer alter the committed fixture. Existing all-replay coverage remains unchanged.
Independent review
Portability findings were fixed before publication. Final independent validation: 7 provenance tests and 155 focused/owning tests passed, including all 13 dedicated cases. Ruff, Black and diff checks passed. Windows path simulation and a real autocrlf checkout passed on Linux; native Windows execution remains separate. Remote CI is pending.