Skip to content

ci: add cloud Windows and macOS compatibility checks - #257

Merged
codeasier merged 3 commits into
mainfrom
test/253-cloud-platform-checks
Oct 11, 2026
Merged

codeasier merged 3 commits into
mainfrom
test/253-cloud-platform-checks

Conversation

@codeasier

Copy link
Copy Markdown
Owner

Summary

Implements the bounded Windows/macOS CI portion of #253. This does not close the other end-to-end coverage items in that issue.

  • Add platform.yml: exactly two jobs (windows-latest, macos-latest), Python 3.13 only, complete non-slow collection, fixture provenance first, 20-minute timeout and OS-specific JUnit artifacts. No coverage or scale matrix and no live model calls.
  • Add actual OS tests for absolute/relative Unicode, spaces, # and % paths; encoded SQLite file: read-only URIs; read-only native dataset members; OS-selected scratch directories; cleanup after success and exhaustion; installed console launchers and JSON errors; and handle release before rename/delete.
  • Keep ordinary compatibility tests running. Preserve POSIX permission assertions where supported; retain cache-signature invalidation tests on Windows while respecting its prohibition on replacing open SQLite files; make missing-focus fixtures independent of drive roots.
  • Remove a Windows collection blocker in benchmark helpers. Platforms without POSIX resource.getrusage report unavailable RSS explicitly as null, never as a measured zero.
  • Mark the existing four million-offset pagination cases slow, using the identical one-line overlap with [test] 端到端测试缺口与 CI 分层 #248. This lets this PR run independently from main without duplicating that scale fixture across platforms.

Validation

Linux Python 3.13.5:

  • Fixture provenance: 7 passed.
  • Full non-slow run before the final marker/JUnit-format-only adjustment: 2,620 passed, 14 skipped, 13 deselected in 357.86 seconds. Its 3 JUnit record_property warnings were addressed by selecting the compatible legacy artifact family.
  • Final-tree affected suites, provenance/governance/release checks, pagination selection and diagnostic artifact tests: 260 passed, 2 skipped, 4 deselected, no warnings.
  • Final non-slow collection: 2,630 of 2,647 tests selected; 17 slow cases deselected.
  • Ruff, Black, and git diff --check: passed.
  • basedPyright: 0 errors; 1,745 existing informational warnings.

Windows and macOS execution remains pending. A Linux pass and YAML checks do not establish either platform's success. Review the exact published head's two platform jobs before treating the cross-platform portion as complete. Required Chromium interaction remains in the Linux browser job. No user computer was used, and no live/paid model service was invoked.

Refs #253 and #248.

Independent review approved exact tree af120dec5d044ce1bf6af31a30a0684b3b71788f; 174 focused tests passed, 2 skipped on Linux Python 3.13. Windows/macOS jobs have not yet completed and must be verified on this published head before claiming cross-platform acceptance.

Copy link
Copy Markdown
Owner Author

The first real platform run exposed macOS interpreter-alias assumptions and Windows compatibility failures; these were not skipped or labeled passing. Follow-up head 010e9c200b441c90394c335759b2ba81925989e1 now contains the reviewed fixes.

  • Real product defect: failed snapshot publication attempted to unlink its rollback file while the backup fd was still open. Close-before-unlink now prevents Windows orphan residue. A Linux-executable red/green regression verifies ordering, original bytes and cleanup.
  • Preserve the conservative Windows immutable-cache policy. Correct 24 platform-specific test assumptions (ctime reuse expectations, directory fd availability, symlink target spelling, shell quoting and filename validity) without adding blanket skips; a simulated-Windows tamper regression checks content revalidation.
  • macOS alias tests compare actual interpreter-reported identities through original execution paths, still distinguishing separate venvs from aliases and the base environment.

Independent review approved tree ea207763fbb250f877d7f6266669d19dff092e57: 362 focused tests passed, 1 slow case deselected; Ruff/Black/diff checks passed. Author focused checks/type checking passed. Full final local compatibility validation and the new exact-head Windows/macOS jobs remain pending. The earlier Linux Test workflow was green; it did not establish cross-platform success.

Copy link
Copy Markdown
Owner Author

Published dfb834ea2067ef3215902f1b46dfa8359aca9c20 (reviewed tree 32d64bcfe8d67a04694cc3defe0043c7d421be28) to address repeated Windows CI timeouts. Previous Windows attempts hit the unchanged 20-minute bound without assertion failures; the retry completed 2,397 tests before interruption, not the full suite.

The workflow now uses two deterministic Windows partitions and one full macOS job, with the same 20-minute cap and max-parallel 2. Partitioning occurs after non-slow marker selection. Each job validates a nonempty, disjoint, exhaustive partition plan and uploads full/selected collection identities; no test assertion or skip was relaxed.

Independent collection/review: 2,646 tests, 1,323 per Windows shard. Actual local Linux execution: shard 0 = 1,316 passed + 7 skipped (134.83s); shard 1 = 1,316 passed + 7 skipped (134.53s), zero failures/errors. Independent fail-closed probes passed. Combined local integration also verified the full 2,918-test union split 1,459/1,459 and retained seven nightly gates; product source is unchanged by this follow-up.

New exact-head hosted CI is pending. Local partition execution does not establish Windows/macOS results.

Copy link
Copy Markdown
Owner Author

Final exact-head hosted verification: dfb834ea2067ef3215902f1b46dfa8359aca9c20 is green in both Platform compatibility 38150709958 and Test 38150710079.

  • Windows shard 0: 1,310 passed, 13 capability skips; 7m40s.
  • Windows shard 1: 1,309 passed, 14 capability skips; 11m34s.
  • Windows total: 2,619 passed, 27 skipped. Actual logged manifests contain 1,323 selected node IDs each; disjoint union is exactly the same 2,646-node non-slow collection used by macOS.
  • macOS: 2,632 passed, 14 skipped, 17 slow deselected; 303.27s.
  • All seven applicable Test jobs passed, including Python 3.10–3.13, coverage/critical floors, wheel audit/offline acceptance, provenance and Chromium.

No test removal or raised timeout was needed. Prior timed-out runs remain visible as incomplete attempts. The separate dataset/nightly gate was not run on the PR event; local large-scale evidence remains separate. PR stays draft and unmerged.

Copy link
Copy Markdown
Owner Author

检视结论:approve

对照 #253 跨平台:platform.yml;路径 / URI / 只读 / scratch。产品修复 snapshot_import_backend.py 失败回滚前 close_backup()(Windows 句柄)合理。CI Win×2 shard + macOS non-slow 已绿。

可与 #255/#256 并行提前合。本评论不 approve/merge。

@codeasier codeasier left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,已转为正式 PR。GitHub 不允许作者账号提交 APPROVE,以本评论 + 此前检视评论作为通过记录。可与 #255/#256 并行提前合。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant