Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/prompts/investigate.md
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,11 @@ top-level error is just "command failed" or similarly uninformative,
dig into the artifact logs to find the actual underlying failure
from the command's output.>

<When referencing file:line(s) in code, make it a link specific to this repo and
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be the wrong place (you're in the kind of "template section" of the prompt). I'd expect advice like this at around line 207.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was hoping to avoid too many links (like in all the code walkthrough in Analysis), so put it in this section where it is most needed (to jump straight to the test code / failure).

Not feeling strongly, can move. I can probably ask it to be not too aggressive with linking everything.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me!

SHA. Example:
[server.go:251](https://github.com/cockroachdb/cockroach/blob/<sha>/pkg/server/server.go#L251).
For multi-line sections, e.g. [server.go:251-300], use suffix like #L251-L300>

### Analysis

<Your hypotheses about the failure, ordered by likelihood. For each:
Expand Down