prompts: linkify code refs in investigate.md#164154
prompts: linkify code refs in investigate.md#164154trunk-io[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Epic: none Release note: none
|
😎 Merged successfully - details. |
| dig into the artifact logs to find the actual underlying failure | ||
| from the command's output.> | ||
| <When referencing file:line(s) in code, make it a link specific to this repo and |
There was a problem hiding this comment.
This seems to be the wrong place (you're in the kind of "template section" of the prompt). I'd expect advice like this at around line 207.
There was a problem hiding this comment.
I was hoping to avoid too many links (like in all the code walkthrough in Analysis), so put it in this section where it is most needed (to jump straight to the test code / failure).
Not feeling strongly, can move. I can probably ask it to be not too aggressive with linking everything.
|
Tried this change locally. For #164008, the output is satisfactory: Where the Failure OccursThe test fails with a goroutine leak detected by |
|
Great! Merge whenever. Github also has the nice preview-style things: but I assume you know these and prefer the inline links, which is fine by me. Still LGTM 😄 |
|
/trunk merge |
Yeah, it's less spammy that way. I typically want to click through and see a larger context around the line anyway (but rendering a larger code block inline would make the thing too big, plus it's not clear how much context is needed). |
Epic: none
Release note: none