Skip to content

Comments

prompts: linkify code refs in investigate.md#164154

Merged
trunk-io[bot] merged 1 commit intocockroachdb:masterfrom
pav-kv:investigate-code-links
Feb 23, 2026
Merged

prompts: linkify code refs in investigate.md#164154
trunk-io[bot] merged 1 commit intocockroachdb:masterfrom
pav-kv:investigate-code-links

Conversation

@pav-kv
Copy link
Collaborator

@pav-kv pav-kv commented Feb 23, 2026

Epic: none
Release note: none

Epic: none
Release note: none
@pav-kv pav-kv requested a review from tbg February 23, 2026 15:29
@pav-kv pav-kv requested a review from a team as a code owner February 23, 2026 15:30
@trunk-io
Copy link
Contributor

trunk-io bot commented Feb 23, 2026

😎 Merged successfully - details.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

dig into the artifact logs to find the actual underlying failure
from the command's output.>
<When referencing file:line(s) in code, make it a link specific to this repo and
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be the wrong place (you're in the kind of "template section" of the prompt). I'd expect advice like this at around line 207.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was hoping to avoid too many links (like in all the code walkthrough in Analysis), so put it in this section where it is most needed (to jump straight to the test code / failure).

Not feeling strongly, can move. I can probably ask it to be not too aggressive with linking everything.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me!

Copy link
Member

@tbg tbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM w nit

@pav-kv
Copy link
Collaborator Author

pav-kv commented Feb 23, 2026

Tried this change locally. For #164008, the output is satisfactory:

Where the Failure Occurs

The test fails with a goroutine leak detected by leaktest.AfterTest. The leaked goroutine (1077) is stuck sleeping inside maybeRetryWithWait at work_queue_test.go:377, called from the test goroutine at line 695.

@tbg
Copy link
Member

tbg commented Feb 23, 2026

Great! Merge whenever.

Github also has the nice preview-style things:

time.Sleep(100 * time.Millisecond)

but I assume you know these and prefer the inline links, which is fine by me.

Still LGTM 😄

@tbg
Copy link
Member

tbg commented Feb 23, 2026

/trunk merge

@trunk-io trunk-io bot merged commit 571f4a5 into cockroachdb:master Feb 23, 2026
24 checks passed
@pav-kv
Copy link
Collaborator Author

pav-kv commented Feb 23, 2026

I assume you know these and prefer the inline links, which is fine by me

Yeah, it's less spammy that way. I typically want to click through and see a larger context around the line anyway (but rendering a larger code block inline would make the thing too big, plus it's not clear how much context is needed).

@pav-kv pav-kv deleted the investigate-code-links branch February 23, 2026 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants