Skip to content

No double backdrop for openspace #12523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hry-gh merged 2 commits into from
Jun 28, 2026
Merged

No double backdrop for openspace #12523

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4444642
no double backdrop for openspace
Drulikar Jun 25, 2026
8fdbaa8
optimize slightly
Drulikar Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions code/game/turfs/open_space.dm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,9 @@ GLOBAL_DATUM_INIT(openspace_backdrop_one_for_all, /atom/movable/openspace_backdr
var/turf/below = get_turf_below()
var/depth = 0
while(below)
new /obj/vis_contents_holder(src, below, depth)
if(!istransparentturf(below))
var/below_transparent = istransparentturf(below)
new /obj/vis_contents_holder(src, below, depth, !below_transparent || !istype(below, /turf/open_space))
if(!below_transparent)
break
below = SSmapping.get_turf_below(below)
depth++
Expand Down
5 changes: 3 additions & 2 deletions code/game/turfs/turf.dm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,10 +132,11 @@
mouse_opacity = MOUSE_OPACITY_TRANSPARENT
anchored = TRUE

/obj/vis_contents_holder/Initialize(mapload, vis, offset)
/obj/vis_contents_holder/Initialize(mapload, vis, offset, backdrop=TRUE)
. = ..()
plane -= offset
vis_contents += GLOB.openspace_backdrop_one_for_all
if(backdrop)
vis_contents += GLOB.openspace_backdrop_one_for_all
vis_contents += vis
name = null // Makes it invisible on right click

Expand Down