No double backdrop for openspace#12523
Merged
Merged
Conversation
cmss13-ci
Bot
added
Fix
hry-gh
approved these changes
Jun 28, 2026
github-project-automation
Bot
moved this from Awaiting Review
to Partially Approved / Mergeable
in Review Backlog
github-project-automation
Bot
moved this from Partially Approved / Mergeable
to Merged
in Review Backlog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the pull request
This PR simply makes it where an openspace looking at an openspace does not add the openspace backdrop (causing it to be doubled+ up). I sort of want to also try just making it where openspaces don't even put other openspaces into vis contents, but then things moving around in that intermediate space are either going to have to update vis contents (which is expensive) or they're just be not rendered at all.
Visually I don't think there's a difference (but there likely would be for airborne things), so even better (see screenshots).
Explain why it's good for the game
Less unnecessary things being rendered, also may be the cause of some visual artifacts when at larger zoom levels.
Testing Photographs and Procedure
Screenshots & Videos
Before:
After:
Changelog
🆑 Drathek
fix: Openspace no longer doubles up the openspace backdrop when viewing an intermediate openspace
/:cl: