Skip to content

Allow Per-task allowed languages - #1486

Merged
prandla merged 12 commits into
cms-dev:mainfrom
pxsit:per-task-lang
Aug 6, 2025
Merged

Allow Per-task allowed languages#1486
prandla merged 12 commits into
cms-dev:mainfrom
pxsit:per-task-lang

Conversation

@pxsit

@pxsit pxsit commented Jul 28, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Closes #1155

prandla
prandla requested changes Jul 31, 2025
View reviewed changes

@prandla prandla left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you also changed the UI of the "allowed languages" input in AWS. I think that should be moved into a separate PR, where we can make it consistent between the contest-wide and per-task language selection.

Also, the "compilation commands" list in the task description page should show only the enabled languages. Also, the "contest overview" table should show the correct file extensions in the "files" column.

Comment thread cms/db/__init__.py Outdated
Comment thread cms/server/contest/templates/task_submissions.html Outdated
Comment thread cms/server/contest/templates/test_interface.html
Comment thread cmscontrib/updaters/update_47.sql Outdated
Comment thread cmscontrib/updaters/update_47.sql Outdated
Comment thread cms/server/contest/templates/task_submissions.html Outdated
Comment thread cms/db/task.py Outdated
@pxsit
pxsit requested a review from prandla August 1, 2025 10:47
@prandla

prandla commented Aug 1, 2025

Copy link
Copy Markdown
Member

I see you also changed the UI of the "allowed languages" input in AWS. I think that should be moved into a separate PR, where we can make it consistent between the contest-wide and per-task language selection.

Also, the "compilation commands" list in the task description page should show only the enabled languages. Also, the "contest overview" table should show the correct file extensions in the "files" column.

You still haven't addressed these comments.

prandla
prandla reviewed Aug 1, 2025
View reviewed changes
Comment thread cms/server/admin/handlers/contest.py Outdated
@prandla
prandla merged commit f95d7ec into cms-dev:main Aug 6, 2025
3 of 4 checks passed
@pxsit
pxsit deleted the per-task-lang branch August 6, 2025 15:58
@prandla prandla mentioned this pull request Aug 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@prandla prandla prandla approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Per-task allowed languages

2 participants

@pxsit @prandla