CWS: fix submission language selector - #1519
Merged
Merged
Conversation
veluca93
approved these changes
Aug 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1486 broke the JS for language selection. I guess it's partially my fault for not locally testing it enough...
CWS doesn't use the js_init block, so this code was never getting evaluated at all. This seems like a weird failure mode in jinja, the entire block just gets completely ignored with no error?
I moved it to the correct additional_js block; and fixed the logic in test_interface. (that one has all tasks on the same page, so one global TASK_LANGUAGES isn't enough.)