Skip to content

Fix possible IntegrityError when deleting task that is part of a contest #1470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
prandla merged 2 commits into from
Jul 23, 2025
Merged

Fix possible IntegrityError when deleting task that is part of a contest #1470

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cfb37e8
Fix possible IntegrityError when deleting task that has a contest
prandla Jul 18, 2025
7fbf8e6
Merge branch 'main' into bugfix-delete-task
prandla Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions cms/server/admin/handlers/task.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,16 +500,19 @@ def delete(self, task_id):
num = task.num

self.sql_session.delete(task)
self.sql_session.flush()
# Keeping the tasks' nums to the range 0... n - 1.
if contest_id is not None:
following_tasks: list[Task] = (
self.sql_session.query(Task)
.filter(Task.contest_id == contest_id)
.filter(Task.num > num)
.order_by(Task.num)
.all()
)
for task in following_tasks:
task.num -= 1
self.sql_session.flush()
if self.try_commit():
self.service.proxy_service.reinitialize()

Expand Down
3 changes: 3 additions & 0 deletions cmscontrib/RemoveTask.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,14 +47,17 @@ def remove_task(task_name: str):
num = task.num
contest_id = task.contest_id
session.delete(task)
session.flush()
# Keeping the tasks' nums to the range 0... n - 1.
if contest_id is not None:
following_tasks = session.query(Task)\
.filter(Task.contest_id == contest_id)\
.filter(Task.num > num)\
.order_by(Task.num)\
.all()
for task in following_tasks:
task.num -= 1
session.flush()
session.commit()
print("Task `%s' removed." % task_name)

Expand Down