Fix possible IntegrityError when deleting task that is part of a contest - #1470
Merged
Conversation
pxsit
approved these changes
Jul 18, 2025
Member
Author
|
I noticed #469 which seems to also be related to the requirement that |
veluca93
approved these changes
Jul 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1065 noticed this bug and fixed it for the "remove task for contest" case. However, the same logic was in two other places that could still cause the error.
For the bug to happen, you need the ID order of the shifted tasks to not match the order they have in the contest. In this case, psycopg apparently attempts to update the tasks in order of ID, which causes an integrity error after the first update, because the updates aren't batched properly.