Repository navigation
chore(checks): graduate word-limit and self-containment to block - #76
Merged
Merged
Conversation
Both met ADR 0012's 7-clean-day rule in July and were held on 2026-10-12 for specific reasons. Those are now addressed. - self-containment: only flag unprefixed prompts/ and scripts/ paths that point into the plugin's own bundle, so text about a repository under audit is not a finding; add tests; graduate - word-limit: add tests for the counting rule and the finding text; record headroom at graduation; graduate - Append the amendment and graduation entries to ADRs 0009 and 0011 adr-index, adr-amendment-link and claude-md-scope were added on 2026-10-12 and stay at warn until they have seven clean days. Refs #64 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #64. Two of the five warn-level checks graduate. Fifteen of eighteen checks now block.
self-containment. It flagged every unprefixedprompts/…orscripts/…path in plugin text. That would have caught a sentence like "look at scripts/deploy.sh in the target repo", which the reverse pass could reasonably say. It now flags a path only when it points into the plugin's own bundle. A typo inside a real bundled directory still counts.word-limit. No logic change. New tests cover the counting rule and the finding text.Why now, when the issue says 2026-10-19
That date applies to the three checks added on 2026-10-12. These two were added in July and have had zero findings in every CI run since 2026-07-27. They were held for specific reasons, recorded in ADRs 0009 and 0011:
self-containment: "confirm on real edits or tighten first". Both done.word-limit: wait for a clean cycle that includes prompt edits. Not met: no prompt has changed since 0.5.0. It is replaced with unit tests and a headroom measurement, and ADR 0009 says so.What block means for word limits
Median headroom is 41 words across 101 prompts. Two prompts have none:
identify-core-objective(150 of 150) andformat-hypothesis-statement(149 of 150). The next edit that adds words to either will fail CI until the prompt is trimmed or its limit is raised by a recorded decision.Not in this PR
adr-index,adr-amendment-linkandclaude-md-scopestay at warn. They are one day old and ADR 0012 requires seven clean days or a real catch.Test plan
python -m unittest discover -s checks/tests— 48 tests passpython checks/run_checks.py --ci --require-validator— 0 findingsADR impact
🤖 Generated with Claude Code