Repository navigation
fix(checks): make the manifest check graduatable and graduate it - #68
Merged
Merged
Conversation
The manifest check reported a finding whenever the claude CLI was absent, so at block status it would have stopped every local session on a machine without the CLI. That kept it at warn in the first graduation. - Report a missing CLI as a note locally; frontmatter fields are still checked - Add --require-validator, passed by CI, which makes a missing CLI a finding so the official validator cannot silently stop running there - Graduate manifest warn -> block; append the log entry to ADR 0008 - Add unit tests for the three cases Closes #63 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #63.
claudeCLI is now a note on themanifestcheck, not a finding. The frontmatter-field half of the check still runs without the CLI.--require-validatorflag, which CI passes. There a missing CLI is a finding, so removing the install step cannot silently drop the official validator.manifestgraduates from warn to block. It has had zero findings in CI since the CLI was installed there on 2026-09-02. Thirteen of eighteen checks now block.Cost
No new CI step. One flag added to the existing suite invocation and three unit tests.
Test plan
manifestpasses with a note, exit 0--require-validator:manifestreports a blockerpython -m unittest discover -s checks/tests— 29 tests passADR impact
🤖 Generated with Claude Code