fix: clarify custom domain route labels - #15523
Draft
yomna-shousha wants to merge 1 commit into
Draft
Conversation
|
@cloudflare/autoconfig
@cloudflare/build-output-utils
@cloudflare/codemods
@cloudflare/config
create-cloudflare
@cloudflare/deploy-helpers
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-functions
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-plugin
@cloudflare/workers-auth
@cloudflare/workers-editor-shared
@cloudflare/workers-utils
wrangler
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR solves
Custom-domain trigger output currently renders
enabled: falseas[disabled, previews: enabled]. This can imply that the whole route is disabled, although only the production hostname is disabled and Preview domains remain enabled.Changes
enabledvalues asproduction: enabledorproduction: disabled.renderRoute()unit coverage and update the affected Wrangler assertion.This changes rendered output only. It does not rename configuration fields or change types, schemas, API payloads, deployment behavior, conflict prompts, Preview behavior, or provisioning output. There is no configuration or API compatibility impact.
Tests
pnpm --filter @cloudflare/deploy-helpers exec vitest run tests/publish-routes.test.tspnpm --filter wrangler exec vitest run src/__tests__/deploy/routes.test.tspnpm exec oxfmt --check packages/deploy-helpers/src/triggers/publish-routes.ts packages/deploy-helpers/tests/publish-routes.test.ts packages/wrangler/src/__tests__/deploy/routes.test.tspnpm exec oxlint --deny-warnings --type-aware packages/deploy-helpers/src/triggers/publish-routes.ts packages/deploy-helpers/tests/publish-routes.test.ts packages/wrangler/src/__tests__/deploy/routes.test.tspnpm --filter @cloudflare/deploy-helpers check:typepnpm --filter @cloudflare/deploy-helpers type:testspnpm --filter wrangler check:type