Skip to content

fix: clarify custom domain route labels - #15523

Draft
yomna-shousha wants to merge 1 commit into
cloudflare:mainfrom
yomna-shousha:yomna/custom-domain-route-labels
Draft

fix: clarify custom domain route labels#15523
yomna-shousha wants to merge 1 commit into
cloudflare:mainfrom
yomna-shousha:yomna/custom-domain-route-labels

Conversation

@yomna-shousha

Copy link
Copy Markdown
Contributor

What this PR solves

Custom-domain trigger output currently renders enabled: false as [disabled, previews: enabled]. This can imply that the whole route is disabled, although only the production hostname is disabled and Preview domains remain enabled.

Changes

  • Render explicit enabled values as production: enabled or production: disabled.
  • Keep the existing Preview labels and omit either label when its configuration value is undefined.
  • Add focused renderRoute() unit coverage and update the affected Wrangler assertion.

This changes rendered output only. It does not rename configuration fields or change types, schemas, API payloads, deployment behavior, conflict prompts, Preview behavior, or provisioning output. There is no configuration or API compatibility impact.

Tests

  • pnpm --filter @cloudflare/deploy-helpers exec vitest run tests/publish-routes.test.ts
  • pnpm --filter wrangler exec vitest run src/__tests__/deploy/routes.test.ts
  • pnpm exec oxfmt --check packages/deploy-helpers/src/triggers/publish-routes.ts packages/deploy-helpers/tests/publish-routes.test.ts packages/wrangler/src/__tests__/deploy/routes.test.ts
  • pnpm exec oxlint --deny-warnings --type-aware packages/deploy-helpers/src/triggers/publish-routes.ts packages/deploy-helpers/tests/publish-routes.test.ts packages/wrangler/src/__tests__/deploy/routes.test.ts
  • pnpm --filter @cloudflare/deploy-helpers check:type
  • pnpm --filter @cloudflare/deploy-helpers type:tests
  • pnpm --filter wrangler check:type

@changeset-bot

changeset-bot Bot commented Sep 5, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 029f406

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new

pkg-pr-new Bot commented Sep 5, 2026

Copy link
Copy Markdown
@cloudflare/autoconfig

npm i https://pkg.pr.new/@cloudflare/autoconfig@15523

@cloudflare/build-output-utils

npm i https://pkg.pr.new/@cloudflare/build-output-utils@15523

@cloudflare/codemods

npm i https://pkg.pr.new/@cloudflare/codemods@15523

@cloudflare/config

npm i https://pkg.pr.new/@cloudflare/config@15523

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@15523

@cloudflare/deploy-helpers

npm i https://pkg.pr.new/@cloudflare/deploy-helpers@15523

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@15523

miniflare

npm i https://pkg.pr.new/miniflare@15523

@cloudflare/pages-functions

npm i https://pkg.pr.new/@cloudflare/pages-functions@15523

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@15523

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@15523

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@15523

@cloudflare/vitest-plugin

npm i https://pkg.pr.new/@cloudflare/vitest-plugin@15523

@cloudflare/workers-auth

npm i https://pkg.pr.new/@cloudflare/workers-auth@15523

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@15523

@cloudflare/workers-utils

npm i https://pkg.pr.new/@cloudflare/workers-utils@15523

wrangler

npm i https://pkg.pr.new/wrangler@15523

commit: 029f406

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Untriaged

Development

Successfully merging this pull request may close these issues.

2 participants