Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .jules/bolt.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
## 2024-05-18 - Optimize string allocations in Casing conversions
**Learning:** In Rust, avoid `.collect::<Vec<_>>().join("")` when you just want to concatenate strings. Collecting into a `Vec` allocates unnecessary intermediate memory.
**Action:** Use `.collect::<String>()` directly on an iterator that yields string-like objects to prevent unnecessary `Vec` allocations.
10 changes: 4 additions & 6 deletions xdk-lib/src/casing.rs
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,8 @@ impl Casing {
result
}
}
Casing::Pascal => words
.iter()
.map(|w| pascal_case(w))
.collect::<Vec<_>>()
.join(""),
// Performance optimization: Using `.collect::<String>()` instead of `.collect::<Vec<_>>().join("")` avoids an intermediate Vec allocation
Casing::Pascal => words.iter().map(|w| pascal_case(w)).collect::<String>(),
Casing::Kebab => words.join("-").to_lowercase(),
Casing::ScreamingSnake => words.join("_").to_uppercase(),
}
Expand Down Expand Up @@ -118,6 +115,7 @@ pub fn camel_case(value: &str) -> String {
let mut chars = pascal.chars();
match chars.next() {
None => String::new(),
Some(first) => first.to_lowercase().collect::<String>() + chars.as_str(),
// Performance optimization: Avoids iterator collection overhead.
Some(first) => first.to_lowercase().to_string() + chars.as_str(),
}
}
Loading