Skip to content

Update the defaultValue check to allow for falsy and undefined values #4838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
JasonAtClockwork wants to merge 2 commits into
base: master
Choose a base branch
from
+2 −1
Draft

Update the defaultValue check to allow for falsy and undefined values #4838

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a9fe858
Update the defaultValue check to allow for falsy and undefined values
JasonAtClockwork Apr 17, 2026
4701ec4
Merge branch 'master' into jlarabie/ts-default-values
JasonAtClockwork Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion crates/bindings-typescript/src/lib/table.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,7 +411,8 @@ export function table<Row extends RowObj, const Opts extends TableOpts<Row>>(
});
}

if (meta.defaultValue) {
// Check for defaultValue on the property to allow for 0, false, '', and undefined as defaults
if (Object.prototype.hasOwnProperty.call(meta, 'defaultValue')) {
const writer = new BinaryWriter(16);
builder.serialize(writer, meta.defaultValue);
defaultValues.push({
Expand Down
Loading