Update the defaultValue check to allow for falsy and undefined values#4838
Draft
JasonAtClockwork wants to merge 2 commits intomasterfrom
Draft
Update the defaultValue check to allow for falsy and undefined values#4838JasonAtClockwork wants to merge 2 commits intomasterfrom
JasonAtClockwork wants to merge 2 commits intomasterfrom
Conversation
JasonAtClockwork
added
the
bugfix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
This fixes a bug in TypeScript table default serialization where falsy defaults like 0, '', false, and explicit undefined were treated as if no default was provided. I did this as a property check in order to allow
undefinedwhich becomes None() as the API allowsT | undefined.Closes: #4700
API and ABI breaking changes
N/A
Expected complexity level and risk
1 - Simple change to check the default value was added as a property
Testing