Skip to content

fix: Serialize webhook deploys to prevent ansible-pull races #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VedantMadane wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: Serialize webhook deploys to prevent ansible-pull races #205

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b0e5306
fix: Serialize webhook deploys to prevent ansible-pull races
VedantMadane Aug 24, 2026
4cf86ac
fix: serialize webhook deploys with a process-wide lock
VedantMadane Aug 24, 2026
2737814
fix: serialize webhook deploys with DEPLOY_LOCK
VedantMadane Aug 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions roles/webhook/files/src/restart.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,14 +42,13 @@ fn try_run(command: Option<&String>, service: &str) -> bool {
/// - `name`: Name of the service to restart
/// - `service`: Specific deployment configuration for that service.
/// - `default`: Default deployment configuration.
///
/// Holds `lock_state` for the full restart sequence so concurrent webhook
/// deliveries cannot run overlapping ansible-pull deploys (#193).
pub fn restart(name: &str, service: &Service, default: &Service, lock_state: Arc<Mutex<()>>) -> bool {
let _deploy_guard = lock_state.lock().unwrap_or_else(|e| e.into_inner());
let _enter = span!(Level::INFO, "service", name).entered();

if lock_state.lock().is_err() { // If another thread crashed, clear poison because we don't care
// about the state
lock_state.clear_poison();
}

tracing::info!("Restarting...");

let span = span!(Level::DEBUG, "stop_command").entered();
Expand Down Expand Up @@ -102,4 +101,4 @@ pub fn restart(name: &str, service: &Service, default: &Service, lock_state: Arc

tracing::info!("Completed !");
true
}
}