fix: Serialize webhook deploys to prevent ansible-pull races - #205
Open
VedantMadane wants to merge 3 commits into
Open
fix: Serialize webhook deploys to prevent ansible-pull races#205VedantMadane wants to merge 3 commits into
VedantMadane wants to merge 3 commits into
Conversation
- init.yaml: serialize concurrent deploys with flock Fixes clicepfl#193 Signed-off-by: Vedant Madane <6527493+VedantMadane@users.noreply.github.com>
Prevent concurrent ansible-pull invocations when multiple webhook deliveries arrive close together (Fixes clicepfl#193). - Add DEPLOY_LOCK in restart.rs around the full restart sequence - Revert incorrect init.yaml flock no-op from an earlier attempt Signed-off-by: Vedant Madane <6527493+VedantMadane@users.noreply.github.com>
Hold a process-wide mutex around restart()/ansible-pull so concurrent webhook deliveries cannot race the same repo checkout. Fixes clicepfl#193 Signed-off-by: Vedant Madane <6527493+VedantMadane@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Serialize webhook deploys to prevent ansible-pull races
Changes
Fixes #193