Fix matching and lexer performance - #153
Merged
Merged
Conversation
…d text that breaks it
…void quadratic lexing and consuming
chrisjenkinson
force-pushed
the
claude/matching-and-tokens
branch
from
September 25, 2026 09:30
6f81d4d to
fe86448
Compare
chrisjenkinson
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes several problems in matching and speeds up lexing:
SimpleTextMatchermatches all remaining text, including newlines. Before, it stopped at the first\n, and the next position then failed withNoTokenFoundException.RegexFinderthrowsRegexFailedExceptionwhenpreg_match()fails, instead of treating the failure as no match.allkey contract is documented onMatcherInterfaceand enforced. A match whoseallis missing, isn't a string, or isn't at the start of the remaining text throwsInvalidMatchedTextException, naming the matcher. This catches matchers that forget theAanchor, which before could silently produce wrong tokens or a misleading ambiguity error.Cursortracks a byte offset andTokenStreama current index, so lexing and consuming no longer take quadratic time. Tokenising a 609 KB, 16,000-line document went from 11.2 s to 0.2 s.