Give tokens and token exceptions a line and column - #154
Merged
Merged
Conversation
chrisjenkinson
force-pushed
the
claude/token-positions
branch
from
September 25, 2026 09:33
767ee5e to
a15b6e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Token::getPosition()always threw a TypeError because nothing set a position. This implements it and uses the position in the lexer's exceptions:Cursortracks the line and column as it advances, both 1-based, with columns counted in characters.Tokentakes itsTokenPositionin the constructor, andsetPosition()is gone.NoTokenFoundExceptionandAmbiguousTokenFoundExceptionmessages show the line, column and the rest of the line (capped at 100 characters) instead of all the remaining text. The full text is still available through the getters.Breaking changes: the
Token,NoTokenFoundExceptionandAmbiguousTokenFoundExceptionconstructors now require aTokenPosition, andguardAgainstWrongNumberOfMatches()takes one too.