Skip to content

ENH: Refactor simulation task#114

Open
mberz wants to merge 3 commits into
devfrom
refactor/simulation_task
Open

ENH: Refactor simulation task#114
mberz wants to merge 3 commits into
devfrom
refactor/simulation_task

Conversation

@mberz

@mberz mberz commented Jun 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Proposed changes

  • Separate the xlsx export from the simulation task
    • Created new shared celery task for export
    • Use celery chain to make sure simulation and export tasks are run consecutively
  • Replace the switch methods for RIR synthesis to a universal check if methods return an energy decay curve.

mberz added 3 commits June 18, 2026 17:02
@mberz
ENH: Add function to export IR to wav
b4c9607 
Uses the json file including the IR as input
@mberz
ENH: Separate task for export of xlsx files
710d3b2
@mberz
ENH: Replace switch method statement
2692540 
Replace with a more universal check if the result is an EDC or RIR
This was referenced Jun 22, 2026
Open
Open
@mberz mberz moved this from Backlog to Implementation in progress in CHORAS planning Jun 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

CHORAS planning
Status: Implementation in progress

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mberz