MoD-ART integration#37
Open
Matteo-Scerbo wants to merge 11 commits into
Open
Conversation
mberz
requested changes
Jun 16, 2026
mberz
left a comment
mberz
left a comment
Contributor
There was a problem hiding this comment.
Thanks for submitting the PRs @Matteo-Scerbo,
I have a minor comment on this one.
I'll add more comments in choras-org/simulation-backend#16
File was committed by mistake.
File was committed by mistake.
Contributor
|
Hey @Matteo-Scerbo, I've updated the backend to work without explicitly adding your method to it to run the simulation in choras-org/backend#114. Could you please check if that works for you? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic integration of the MoD-ART model.
The simulation method returns Schroeder curves for each frequency band, so the backend will need to be adapted accordingly.
The integration currently doesn't take advantage of MoD-ART's preprocessing/runtime separation. We can discuss how to handle that to make consecutive runs more efficient.