Repository navigation
Add Arabic as the eighth language (#855) - #865
Merged
Merged
Conversation
Arabic (`ar`, «العربية») is last in LOCALES, right to left like Persian, and keeps Western digits: Chogan.num converts only Persian, and dates use `ar-u-nu-latn` so a date never shows Arabic-Indic digits beside a game's 0-9. Device languages ar and ar-* pick it. - Core strings, every award (ar/dar), the menu, games.json names and summaries, every game's strings and names (nonogram pictures, tower defence maps), manifest description, privacy page titles, the report and issues sites. - Language picker: two rows of four on a phone, one row of eight wide. - Store: new `ar` listing (title, short, full description, eight phone screenshots); the other listings mention eight languages, shortened where they were near Play's 4000 characters. - Tests: tools/tests/lang-ar.js asks for Arabic letters and refuses the Persian-only letters; lists of seven languages now include ar. The translation is machine-made and waits for a native speaker's review. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QY4t6rHpbsoE5aS15nw6Z7
Contributor
Author
Diff reviewWhy it's done this way
Tested
Not tested
|
Both arrived on main after the Arabic branch was cut (#850, #854). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QY4t6rHpbsoE5aS15nw6Z7
This was referenced Nov 12, 2026
…oku themes, Football Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QY4t6nURUboWf82LgW2N4S
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #855
What changed
www/lib/chogan.js):ar(«العربية») last inLOCALES,dir: 'rtl', so the existing right-to-left handling for Persian applies (documentdir, mirrored DOM layouts, back arrows, swipe direction, RTL arrow flips only in DOM grids; canvases stay left to right). Device languagesarandar-*pick it. A core Arabic block andar/daron all 238 awards.Chogan.numconverts only Persian, and the date format isar-u-nu-latn, so dates do not show Arabic-Indic digits next to a game's 0–9. The week still starts on Monday (only Persian starts on Saturday, Profile: this week vs last week (plays, play time, …) #664).games.json(names and summaries), nonogram picture names, tower defence map names, the manifest description, the privacy page titles (the policy text stays English for Arabic, as for French), and the report and issues sites underworker/.chogan.css): two rows of four on a phone, one row of eight from 600px.arlisting (Play's code for Arabic): title, short and full description (3673/4000), and eight phone screenshots fromLANGS=ar tools/screenshots.sh. The other seven full descriptions say "eight languages". de-DE, es-ES and pl-PL were 1–5 characters from Play's 4000, so their language line is now shorter rather than longer.CSS.getPlatformFontsForNodeon Arabic text, including the letters Persian lacks (ة ى ي ك ؤ ئ إ), reports onlyVazirmatn (web)andNunito (web). No system font is used.tools/tests/lang-ar.jsgroup checks that Arabic is listed as RTL with Western digits, that the core and the menu have every key, and that every game's name, summary, string block and award is in Arabic letters with no Persian-only letters (ی ک پ چ ژ گ). It also checks that each game page names itself asgames.jsondoes and that the store listing has a line for every game. Existing checks that listed seven languages now includear.MIN_CHECKSis not raised.CONTRIBUTING.md: eight languages.Proof
node tools/test.js: «همهی 9247 بررسی سبز», exit 0, after merging main (which brought Minesweeper zoom Be able to zoom in #850 and the Sliding Puzzle arrow pad Web form: suggestion (report-20261112-111245-xvzrhq) #854; their new strings are translated too). CI green on b79151c.tools/browser-check.sh: «All pages loaded without console errors (74 of 74)», exit 0.origin/main(files fromgit archive):2 passed, 14 failed, exit 1. Run against this branch:16 passed, 0 failed.document.fonts.ready: menu, profile, language picker, Sudoku, Chess, Hokm, Mahjong, Minesweeper, Way Out, Tanks, Hillrider, Crazy Eights, Backgammon, Jigsaw, 8-Ball, Snooker. No page errors.Not tested / notes
{n}placeholder per string, phrases like «{n} حركات» read correctly only for some counts.ar/changelogs/<code>.txt.