Repository navigation
Football: a goal from the kick-off flick does not count - #878
Merged
Merged
Conversation
One flick from the starting line-up scored almost every time, and the bot learned it, so matches ended without a duel. The kick-off goal is now disallowed and the other team kicks off (#877). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QY4t6rHpbsoE5aS15nw6Z7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #877
Why: a kick-off flick at the right angle scored almost every time, and the bot learned it, so games ended without real play. A goal from the kick-off flick is now disallowed and the other team kicks off; the message says so, no goal banner shows, the bot scores it as a loss, and the flag is saved and restored.
Tested:
node tools/test.js: 9421 green. New grouptestFootballKickofffails 11 checks on old main and passes on the branch.tools/browser-check.sh: 75/75 pages.Not tested: a real phone; Arabic and Hindi strings (those languages are only in open PRs #865 and #869 and will need the new key).