-
-
Notifications
You must be signed in to change notification settings - Fork 133
chore: release v6.1.11 #190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| import { useRef } from 'react' | ||
| import type { BasicTarget } from './domTarget' | ||
| import { getTargetElement } from './domTarget' | ||
|
|
||
| /** | ||
| * Creates a stable identifier for a BasicTarget that can be safely used in effect dependencies. | ||
| * | ||
| * This hook solves the problem where passing unstable function references like `() => document` | ||
| * would cause infinite re-renders when used directly in effect dependency arrays. | ||
| * | ||
| * @param target - The target element (ref, function, or direct element) | ||
| * @param defaultElement - Default element to use if target is undefined | ||
| * @returns A stable reference that only changes when the actual target element changes | ||
| * | ||
| * @example | ||
| * ```tsx | ||
| * // For ref objects: returns the ref itself (stable) | ||
| * const ref = useRef<HTMLDivElement>(null) | ||
| * const key = useStableTarget(ref) // key === ref (stable) | ||
| * | ||
| * // For functions: returns the resolved actual element | ||
| * const key = useStableTarget(() => document) // key === document (stable) | ||
| * | ||
| * // For direct elements: returns the element itself | ||
| * const key = useStableTarget(divElement) // key === divElement (stable) | ||
| * ``` | ||
| */ | ||
| export function useStableTarget<T extends HTMLElement | Element | Window | Document | EventTarget>( | ||
| target?: BasicTarget<T>, | ||
| defaultElement?: T, | ||
| ) { | ||
| const targetRef = useRef(target) | ||
| targetRef.current = target | ||
|
|
||
| // Calculate stable key without memoization | ||
| // For ref objects: return the ref itself (always stable) | ||
| // For functions/direct elements: resolve to the actual element | ||
| let stableKey: any | ||
| if (!target) { | ||
| stableKey = defaultElement ?? null | ||
| } | ||
| else if (typeof target === 'object' && 'current' in target) { | ||
| // Ref object - use the ref itself as the stable key | ||
| stableKey = target | ||
| } | ||
| else { | ||
| // Function or direct element - resolve to actual element | ||
| stableKey = getTargetElement(target, defaultElement) | ||
| } | ||
|
|
||
| return { | ||
| /** The stable key that can be safely used in effect dependencies */ | ||
| key: stableKey, | ||
| /** A ref containing the current target (useful for accessing in effects) */ | ||
| ref: targetRef, | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.