Conversation
- fix(usePageLeave): resolve infinite re-render issue due to unstable handler references - fix(useEventListener): enhance stability to prevent unnecessary re-bindings while supporting ref-based targets - fix(useSticky): address infinite re-render issue with unstable function references as target or scroll element - fix(useMutationObserver): add missing target dependency for correct re-observation - fix(useResizeObserver): fix infinite re-render issue with unstable function references as target - fix(useIntersectionObserver): add missing target dependency for correct re-observation - feat(useStableTarget): introduce new utility hook for creating stable identifiers for BasicTarget parameters to prevent infinite re-renders
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Focuses on stabilizing DOM target handling and fixing re-render loops across hooks, with a minor internal utility addition and docs updates.
useStableTargetto produce stable keys/refs forBasicTargetinputs used in effectsuseEventListener,useIntersectionObserver,useMutationObserver,useResizeObserver, anduseStickyto useuseStableTarget, updating deps totargetKey/elementKeyso listeners/observers re-bind when targets change without infinite loopsusePageLeavenow binds todefaultWindow/defaultDocumentinstead of function targets to avoid unstable deps@reactuses/coreto6.1.11; update changelogs and website content (companies list, generated timestamp)Written by Cursor Bugbot for commit 4b4e531. This will update automatically on new commits. Configure here.