Skip to content

fix: prevent race condition causing 'Already compacted' error #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Bjynt wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: prevent race condition causing 'Already compacted' error #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 18 additions & 5 deletions extensions/auto-compact.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,6 +276,14 @@ export default function autoCompact(pi: ExtensionAPI) {
phase: AutoCompactPhase,
customInstructions?: string,
): void => {
// Guard: if compaction is already in progress, don't start another.
// This prevents races from callers that don't check pendingCompaction.
if (pendingCompaction) return;
// Guard: if the last session entry is already a compaction, pi core will
// throw "Already compacted". Skip to avoid the error.
const entries = ctx.sessionManager.getEntries();
const lastEntry = entries[entries.length - 1];
if (lastEntry?.type === "compaction") return;
pendingCompaction = true;
ctx.compact({
customInstructions,
Expand Down Expand Up @@ -382,11 +390,16 @@ export default function autoCompact(pi: ExtensionAPI) {
if (newMessages) {
truncationAppliedThisTurn = true;
setImmediate(() => {
triggerAutoCompact(
ctx,
"emergency",
"Emergency context truncation was applied. Generate a comprehensive summary.",
);
// Re-check pendingCompaction: another event may have triggered compaction
// while this callback was deferred. Without this check, we race and get
// "Already compacted" from pi core.
if (!pendingCompaction) {
triggerAutoCompact(
ctx,
"emergency",
"Emergency context truncation was applied. Generate a comprehensive summary.",
);
}
});
return { messages: newMessages };
}
Expand Down