fix: prevent race condition causing 'Already compacted' error - #5
Open
Bjynt wants to merge 1 commit into
Open
Conversation
- Add guard in triggerAutoCompact to check pendingCompaction and last entry type - Re-check pendingCompaction in context event handler's setImmediate callback - Prevents duplicate compaction calls from racing and throwing 'Already compacted'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the race condition in the auto-compact extension that causes 'Compaction failed: Already compacted' errors.
Root Cause
The event handler checked then deferred via . Before the callback ran, another event (turn_start, turn_end, session_start) could trigger compaction. When the callback executed, it called without re-checking , causing a second call while one was in progress (or just completed). Pi core then threw 'Already compacted' because the last session entry was already a compaction entry.
Changes
** function**: Added defensive guards at the start:
** event handler's callback**: Added re-check of before calling , preventing the race where another event triggers compaction during the deferral window.
These are minimal, focused changes that address the exact race condition.