Skip to content

WIP - API spec updated to apply required changes from Commonalities r4.3 - #140

Merged
bigludo7 merged 6 commits into
mainfrom
fix133
Jun 28, 2026
Merged

WIP - API spec updated to apply required changes from Commonalities r4.3#140
bigludo7 merged 6 commits into
mainfrom
fix133

Conversation

@bigludo7

@bigludo7 bigludo7 commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

Updated references to common components and error responses, improved request body strictness, and adjusted version number.

What type of PR is this?

Add one of the following kinds:

  • enhancement/feature
  • subproject management

What this PR does / why we need it:

This PR updates the OTPValidation API specification and test definitions to align with CAMARA Commonalities r4.3 (Commonalities 0.8.0).

API specification (cone-time-password-sms.yaml)

  • Updated x-camara-commonalities version from 0.6 to 0.8.0
  • Replaced inline definitions for x-correlator header/parameter, PhoneNumber, and ErrorInfo with $ref to CAMARA_common.yaml, removing duplicated schema definitions
  • Replaced inline Generic401 response with $ref to CAMARA_common.yaml
  • Removed unused XCorrelator schema component (rule S-211)
  • Added mandatory CAMARA info.description section markers (authorization-and-authentication, additional-error-responses, request-body-strictness)

Which issue(s) this PR fixes:

Fixes #133

Special notes for reviewers:

Changelog input

 release-note

Additional documentation

This section can be blank.

docs

Updated references to common components and error responses, improved request body strictness, and adjusted version number.
@bigludo7
bigludo7 marked this pull request as draft June 8, 2026 10:14
@camara-validation

camara-validation Bot commented Jun 8, 2026

Copy link
Copy Markdown

CAMARA Validation — PASS (with warnings)

0 errors, 1 warnings, 2 hints | Profile: standard

View full results

bigludo7 added 2 commits June 9, 2026 17:23
Added mandatory section for identifying phone number from access token.
@bigludo7
bigludo7 marked this pull request as ready for review June 10, 2026 08:00
@bigludo7

Copy link
Copy Markdown
Collaborator Author

@fernandopradocabrillo @rartych I guess you could review this one:

Comment thread code/API_definitions/one-time-password-sms.yaml
bigludo7 and others added 2 commits June 17, 2026 17:26
Co-authored-by: Rafal Artych <121048129+rartych@users.noreply.github.com>
Comment thread code/API_definitions/one-time-password-sms.yaml Outdated
Co-authored-by: Rafal Artych <121048129+rartych@users.noreply.github.com>

@fernandopradocabrillo fernandopradocabrillo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bigludo7
bigludo7 merged commit 8cf8763 into main Jun 28, 2026
3 checks passed
@bigludo7
bigludo7 deleted the fix133 branch June 28, 2026 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Apply Commonalities 0.8.0 enhancements for OTPValidation

3 participants