Skip to content

Enhance API definitions with additional descriptions - #135

Closed
bigludo7 wants to merge 1 commit into
mainfrom
bigludo7-patch-1
Closed

Enhance API definitions with additional descriptions#135
bigludo7 wants to merge 1 commit into
mainfrom
bigludo7-patch-1

Conversation

@bigludo7

@bigludo7 bigludo7 commented Jun 2, 2026

Copy link
Copy Markdown
Collaborator

Added description for XCorrelator schema and OpenID security scheme.

What type of PR is this?

Add one of the following kinds:

  • correction

What this PR does / why we need it:

Added description for XCorrelator schema and OpenID security scheme.

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Changelog input

 release-note
- Added description for XCorrelator schema and OpenID security scheme.

Additional documentation

This section can be blank.

docs

Added description for XCorrelator schema and OpenID security scheme.
@camara-validation

Copy link
Copy Markdown

CAMARA Validation — PASS

0 errors, 0 warnings, 0 hints | Profile: standard

View full results

openId:
type: openIdConnect
openIdConnectUrl: https://example.com/.well-known/openid-configuration
description: OpenID Connect authentication via discovery metadata.

@jpengar jpengar Jun 2, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be replaced by a reference to common artefacts after Spring 26 meta.

securitySchemes:
    openId:
      $ref: "../common/CAMARA_common.yaml#/components/securitySchemes/openId"

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jpengar
To be sure I got it
I replace directly in the yaml

openId:
      type: openIdConnect
      openIdConnectUrl: https://example.com/.well-known/openid-configuration
      description: OpenID Connect authentication via discovery metadata.

by:

openId:
      $ref: "../common/CAMARA_common.yaml#/components/securitySchemes/openId"

correct?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take a look at the following as a reference: camaraproject/ConsentManagement#29. It may help!

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the $ref's to work, you first need to complete the update to release-plan.yaml. As part of the release automation process, a new PR like this one is created: camaraproject/ConsentManagement#28. This copies the corresponding common artefacts to the repository, as indicated in release-plan.yaml.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this is super helpful ! Thanks !

schemas:
XCorrelator:
type: string
description: Correlator string, UUID format recommended but any string matching the pattern can be used

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be replaced by a reference to common artefacts after Spring 26 meta.

components:
  headers:
    x-correlator:
      $ref: "../common/CAMARA_common.yaml#/components/headers/x-correlator"
parameters:
    x-correlator:
      $ref: "../common/CAMARA_common.yaml#/components/parameters/x-correlator"

@bigludo7
bigludo7 marked this pull request as draft June 4, 2026 10:23
@bigludo7

bigludo7 commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator Author

I propose to close this PR
replaced by #140
Kudos to @jpengar for your help :)

@bigludo7 bigludo7 closed this Jun 9, 2026
@bigludo7
bigludo7 deleted the bigludo7-patch-1 branch July 20, 2026 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants