fix(geofencing-subscriptions): resolve S-015 and S-211 validation warnings - #417
Merged
Conversation
…nings Rename local CloudEvent schema to GeofencingNotificationEvent and NotificationEventType to GeofencingEventType, eliminating the bundler name collision that caused the S-015 PascalCase warning (CloudEvent-2). Remove seven unused passthrough schema re-exports (XCorrelator, Latitude, Longitude, Source, DateTime, AccessTokenCredential, PrivateKeyJWTCredential) to resolve the S-211 unused-component warnings. Update the schema reference in geofencing-subscriptions.feature to match the renamed GeofencingNotificationEvent envelope. S-313 hints and G-004 are dismissed and documented in issue #416.
CAMARA Validation — PASS (with warnings)0 errors, 16 warnings, 1 hints | Profile: standard |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
correction
What this PR does / why we need it:
Resolves the S-015 and S-211 validation warnings surfaced by the CAMARA linter in PR #415 (Release Review r4.1 rc).
S-015 (PascalCase schema name): The local schema named
CloudEventingeofencing-subscriptions.yamlcollided with theCloudEventbase schema fromCAMARA_event_common.yaml. When bundled, the local schema was renamed toCloudEvent-2, failing the PascalCase rule. The fix renames the local envelope schema toGeofencingNotificationEventand the associated event-type enum fromNotificationEventTypetoGeofencingEventType, following the same pattern applied in QoSBooking and QosProvisioning.S-211 (unused components): Seven passthrough schema re-exports (
XCorrelator,Latitude,Longitude,Source,DateTime,AccessTokenCredential,PrivateKeyJWTCredential) were defined incomponents/schemasbut never referenced locally. They have been removed.S-313 hints and G-004 warning are dismissed and documented in issue #416: the string-format hints are acceptable for free-form fields per the CAMARA linter FAQ; the scenario count (53 vs max 50) reflects the r4.3 test-plan alignment from PR #414 and is deferred to a future revision.
Which issue(s) this PR fixes:
Fixes #416
Special notes for reviewers:
The external
$reftoCAMARA_event_common.yaml#/components/schemas/CloudEventinsideGeofencingNotificationEventis intentionally unchanged — it refers to the shared CloudEvents 1.0 base schema.Changelog input
Additional documentation