fix(geofencing-subscriptions): resolve remaining S-015 and S-211 warnings - #420
Merged
Merged
Conversation
…ings - Remove unused DeviceIpv4Addr and SingleIpv4Addr schema aliases - Replace inline SubscriptionPermissionDenied403 with a $ref to CAMARA_event_common.yaml#/components/responses/SubscriptionPermissionDenied403 - Wire SubscriptionPermissionDenied403 to all four subscription CRUD endpoints (POST, GET list, GET by ID, DELETE); callback endpoint retains Generic403 - Update geofencing-subscriptions.feature: schema pin for ipv4Address updated from DeviceIpv4Addr to DeviceIpv4Address (canonical name)
CAMARA Validation — PASS (with warnings)0 errors, 13 warnings, 1 hints | Profile: standard |
Collaborator
Author
|
@bigludo7 I had to fix some remaining warnings |
Collaborator
Author
|
hi @bigludo7, please approve if it's ok |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
correction
What this PR does / why we need it:
Three unused-component warnings remained in
geofencing-subscriptions.yamlafter PR #417. This PR resolves all three:
DeviceIpv4Addr(schema): passthrough alias with no internal$refusage. Removed; the test-plan schema pin foripv4Addressupdated fromDeviceIpv4Addrto the canonicalDeviceIpv4Address(defined inCAMARA_common.yaml).SingleIpv4Addr(schema): fully orphaned passthrough alias. Removed.SubscriptionPermissionDenied403(response): correctly defined withPERMISSION_DENIED+SUBSCRIPTION_MISMATCHcodes but never wired to any endpoint. The inline definition is replaced with a$reftoCAMARA_event_common.yaml(consistent with how all other common responses are imported), and the response is wired to all four subscription CRUD operations (POST, GET list, GET by ID, DELETE). The callback/notification endpoint retainsGeneric403.Which issue(s) this PR fixes:
Fixes #419
Special notes for reviewers:
The wiring of
SubscriptionPermissionDenied403to the subscription endpoints is a documentation-only change: it addsSUBSCRIPTION_MISMATCHto the set of 403 codes documented on those operations.Changelog input
Additional documentation
This section can be blank.