Normalize artifact line endings and Gherkin formatting - #678
Conversation
hdamker
left a comment
There was a problem hiding this comment.
Verified independently against main:
git diff -wshows only the new.gitattributes(byte-identical to the template proposed in camaraproject/tooling#112) - everything else is pure line-ending/whitespace normalization, no content changes- all four CRLF files are LF now
- gplint: the 128 mechanical findings are gone; exactly the 16 template-natured warnings remain (to be documented via #676)
- the remaining yamllint finding (trailing space in
Github_templates) is pre-existing onmainand fixed by #673
Merge order: #673 goes first; after a rebase the new Artifacts Lint check runs directly on this PR - expected green.
Thanks @LarryHu0217 - also for including the validation against the pinned toolchain.
|
The prerequisite #673 has merged, and this PR is approved, mergeable, and passing its current checks. Please let me know if any further validation or update is needed before merge. |
|
@LarryHu0217 Thank you for updating this PR. |
05d7158
0c34329 to
05d7158
Compare
|
Rebased on current main and resolved the conflict by retaining the upstream content updates. This PR now applies only the intended .gitattributes and Gherkin formatting changes; the artifact lint check is running. |
hdamker
left a comment
There was a problem hiding this comment.
LGTM - whitespace changes only plus the new file .gitattributes.
What type of PR is this?
What this PR does / why we need it:
Normalizes the common artifacts so their checked-in formatting matches the CAMARA lint configuration:
.gitattributespolicy to keep text files on LF and protect binary formats from conversionThe Gherkin scenarios, steps, examples, and YAML values are unchanged.
Which issue(s) this PR fixes:
Fixes #674
Fixes #675
Does this PR introduce a breaking change?
Special notes for reviewers:
This PR depends on #673, which introduces the Artifacts Lint workflow. I validated the combined #673 + this PR state locally with the same
v1-rctooling pins:artifacts/: passgit diff --ignore-all-spaceover all changed artifacts: no content differencesgit diff --check: passBefore this change, gplint reported 144 warnings. The remaining 16 are the 10 duplicate-scenario-name and 6 unused-template-variable warnings described in #676.
Changelog input
Additional documentation
This section can be blank.