Skip to content

Normalize artifact line endings and Gherkin formatting - #678

Merged
rartych merged 1 commit into
camaraproject:mainfrom
LarryHu0217:codex/common-artifact-format-674-675
Jul 30, 2026
Merged

Normalize artifact line endings and Gherkin formatting#678
rartych merged 1 commit into
camaraproject:mainfrom
LarryHu0217:codex/common-artifact-format-674-675

Conversation

@LarryHu0217

Copy link
Copy Markdown
Contributor

What type of PR is this?

  • correction
  • cleanup

What this PR does / why we need it:

Normalizes the common artifacts so their checked-in formatting matches the CAMARA lint configuration:

The Gherkin scenarios, steps, examples, and YAML values are unchanged.

Which issue(s) this PR fixes:

Fixes #674
Fixes #675

Does this PR introduce a breaking change?

  • Yes
  • No

Special notes for reviewers:

This PR depends on #673, which introduces the Artifacts Lint workflow. I validated the combined #673 + this PR state locally with the same v1-rc tooling pins:

Before this change, gplint reported 144 warnings. The remaining 16 are the 10 duplicate-scenario-name and 6 unused-template-variable warnings described in #676.

Changelog input

 release-note
- Normalized common artifact line endings to LF and added repository-level Git attributes
- Aligned Gherkin feature template indentation and trailing whitespace with CAMARA lint rules

Additional documentation

This section can be blank.

docs

hdamker
hdamker previously approved these changes Jul 17, 2026

@hdamker hdamker left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified independently against main:

  • git diff -w shows only the new .gitattributes (byte-identical to the template proposed in camaraproject/tooling#112) - everything else is pure line-ending/whitespace normalization, no content changes
  • all four CRLF files are LF now
  • gplint: the 128 mechanical findings are gone; exactly the 16 template-natured warnings remain (to be documented via #676)
  • the remaining yamllint finding (trailing space in Github_templates) is pre-existing on main and fixed by #673

Merge order: #673 goes first; after a rebase the new Artifacts Lint check runs directly on this PR - expected green.

Thanks @LarryHu0217 - also for including the validation against the pinned toolchain.

PedroDiez
PedroDiez previously approved these changes Jul 20, 2026

@PedroDiez PedroDiez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bigludo7
bigludo7 previously approved these changes Jul 20, 2026

@bigludo7 bigludo7 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LarryHu0217

Copy link
Copy Markdown
Contributor Author

The prerequisite #673 has merged, and this PR is approved, mergeable, and passing its current checks. Please let me know if any further validation or update is needed before merge.

@rartych

rartych commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

@LarryHu0217 Thank you for updating this PR.
Some earlier prepared PRs have been merged creating new conflicts.
Since the changes here are rather mechanical, I suppose it would be easier to merge #670 and #680 first and then do the final update here. Thank you for your understanding!

@LarryHu0217
LarryHu0217 dismissed stale reviews from hdamker, PedroDiez, and bigludo7 via 05d7158 July 28, 2026 18:01
@LarryHu0217
LarryHu0217 force-pushed the codex/common-artifact-format-674-675 branch from 0c34329 to 05d7158 Compare July 28, 2026 18:01
@LarryHu0217

Copy link
Copy Markdown
Contributor Author

Rebased on current main and resolved the conflict by retaining the upstream content updates. This PR now applies only the intended .gitattributes and Gherkin formatting changes; the artifact lint check is running.

@hdamker hdamker left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - whitespace changes only plus the new file .gitattributes.

@hdamker

hdamker commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

@camaraproject/commonalities_codeowners Please re-review and approve the PR, so that @rartych can merge it and I can rebase #683 on main branch and open for review.

@PedroDiez PedroDiez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rartych rartych left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rartych
rartych merged commit c6dec5d into camaraproject:main Jul 30, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature file templates: mechanical lint cleanup (indentation, trailing spaces) Normalize line endings of the artifacts to LF and add a .gitattributes

5 participants