Align notification template with CAMARA lint rules - #679
Conversation
|
@LarryHu0217 thanks for picking this up — and apologies first: the description of #677 was accidentally empty when you started (fixed now), so you could only work from the title. You resolved the findings in a perfectly reasonable way given that. With the full description in place, the intended resolution for the Your Would you like to rework the PR along these lines? Happy to review quickly. One heads-up: once #673 merges, |
hdamker
left a comment
There was a problem hiding this comment.
LGTM now.
Note for reviewers: the change helps also to avoid that the same rules as for the API's {apiRoot} are applied by Validation.
What type of PR is this?
What this PR does / why we need it:
Aligns
sample-notification.yamlwith the notification sink semantics described in #677:apiRoottosinkRoothttps://endpoint.example.com, matching the Sink examplenotificationsBearerAuthso the security scheme passes the r4 Spectral description ruleWhich issue(s) this PR fixes:
Fixes #677
Does this PR introduce a breaking change?
Special notes for reviewers:
This PR depends on #673, which introduces the Artifacts Lint workflow. I validated the combined #673 + this PR state locally with the same
v1-rctooling pins:artifacts/: passsample-notification.yaml: no issue-specific findingsgit diff --check: passChangelog input
Additional documentation
This section can be blank.