Skip to content

fix: correct OAS schema refs and response body assertions in test definitions #230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rartych merged 1 commit into from
Jul 30, 2026
Merged

fix: correct OAS schema refs and response body assertions in test definitions #230

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions code/Test_definitions/call-forwarding-signal-retrieveCallForwarding.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ Feature: CAMARA Call Forwarding Signal API, vwip - Operation retrieveCallForwar
And the response header "Content-Type" is "application/json"
And the response header "x-correlator" has same value as the request header "x-correlator"
# The response has to comply with the generic response schema which is part of the spec
And the response body complies with the OAS schema at "/components/schemas/CallForwardingSignal"
And the response body complies with the OAS schema at "#/components/schemas/CallForwardingSignal"

@call_forwarding_signal_01.1_generic_success_scenario_3-legs
Scenario: Common validations for any success scenario with 3-legs authentication
Expand All @@ -41,7 +41,7 @@ Feature: CAMARA Call Forwarding Signal API, vwip - Operation retrieveCallForwar
And the response header "Content-Type" is "application/json"
And the response header "x-correlator" has same value as the request header "x-correlator"
# The response has to comply with the generic response schema which is part of the spec
And the response body complies with the OAS schema at "/components/schemas/CallForwardingSignal"
And the response body complies with the OAS schema at "#/components/schemas/CallForwardingSignal"

#CFS inactive: phone number defined by phoneNumber (2-legs authentication) and the CFS status for the phone number is known by the network.
@call_forwarding_signal_02_call_forwarding_check_not_active_phoneNumber
Expand All @@ -52,7 +52,7 @@ Feature: CAMARA Call Forwarding Signal API, vwip - Operation retrieveCallForwar
Then the response status code is 200
And the response header "Content-Type" is "application/json"
And the response header "x-correlator" has same value as the request header "x-correlator"
And the response body is a string with the value "inactive"
And the response body is an array of strings with the possible values ["inactive"]

#CFS inactive: phone number obtained from the access token (3-legs authentication) and the CFS status for the phone number is known by the network. phoneNumber not set
@call_forwarding_signal_03_call_forwarding_check_not_active_access_token
Expand All @@ -64,7 +64,7 @@ Feature: CAMARA Call Forwarding Signal API, vwip - Operation retrieveCallForwar
Then the response status code is 200
And the response header "Content-Type" is "application/json"
And the response header "x-correlator" has same value as the request header "x-correlator"
And the response body is a string with the value "inactive"
And the response body is an array of strings with the possible values ["inactive"]

#CFS active: phone number defined by phoneNumber (2-legs authentication) and the CFS status for the phone number is known by the network.
@call_forwarding_signal_04_call_forwarding_check_active_phoneNumber
Expand Down Expand Up @@ -103,7 +103,7 @@ Feature: CAMARA Call Forwarding Signal API, vwip - Operation retrieveCallForwar

@call_forwarding_signal_400.3_C02.01_phone_number_not_schema_compliant
Scenario: Phone number value does not comply with the schema (with 2-legs authentication)
Given the request body property "$.phoneNumber" does not comply with the OAS schema at "/components/schemas/PhoneNumber"
Given the request body property "$.phoneNumber" does not comply with the OAS schema at "#/components/schemas/PhoneNumber"
When the HTTP "POST" request is sent
Then the response status code is 400
And the response property "$.status" is 400
Expand Down
8 changes: 4 additions & 4 deletions code/Test_definitions/call-forwarding-signal-retrieveUnconditionalCallForwarding.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ Feature: CAMARA Call Forwarding Signal API, vwip - Operation retrieveUnconditio
And the response header "Content-Type" is "application/json"
And the response header "x-correlator" has same value as the request header "x-correlator"
# The response has to comply with the generic response schema which is part of the spec
And the response body complies with the OAS schema at "/components/schemas/UnconditionalCallForwardingSignal"
And the response body complies with the OAS schema at "#/components/schemas/UnconditionalCallForwardingSignal"

@call_forwarding_signal_01.1_generic_success_scenario_3-legs
Scenario: Common validations for any success scenario with 3-legs authentication
Expand All @@ -42,7 +42,7 @@ Feature: CAMARA Call Forwarding Signal API, vwip - Operation retrieveUnconditio
And the response header "Content-Type" is "application/json"
And the response header "x-correlator" has same value as the request header "x-correlator"
# The response has to comply with the generic response schema which is part of the spec
And the response body complies with the OAS schema at "/components/schemas/UnconditionalCallForwardingSignal"
And the response body complies with the OAS schema at "#/components/schemas/UnconditionalCallForwardingSignal"

# phone number defined by phoneNumber (2-legs authentication) and the CFS status for the phone number is known by the network.
@call_forwarding_signal_02_unconditional_phoneNumber
Expand All @@ -53,7 +53,7 @@ Feature: CAMARA Call Forwarding Signal API, vwip - Operation retrieveUnconditio
Then the response status code is 200
And the response header "Content-Type" is "application/json"
And the response header "x-correlator" has same value as the request header "x-correlator"
And the response body complies with the OAS schema at "/components/schemas/UnconditionalCallForwardingSignal"
And the response body complies with the OAS schema at "#/components/schemas/UnconditionalCallForwardingSignal"
And the response body property "$.active" is one of: ["true", "false"]

# phone number defined by access token and the CFS status for the phone number is known by the network. phoneNumber not set
Expand Down Expand Up @@ -82,7 +82,7 @@ Feature: CAMARA Call Forwarding Signal API, vwip - Operation retrieveUnconditio

@call_forwarding_signal_400.3_C02.01_phone_number_not_schema_compliant
Scenario: Phone number value does not comply with the schema (with 2-legs authentication)
Given the request body property "$.phoneNumber" does not comply with the OAS schema at "/components/schemas/PhoneNumber"
Given the request body property "$.phoneNumber" does not comply with the OAS schema at "#/components/schemas/PhoneNumber"
When the HTTP "POST" request is sent
Then the response status code is 400
And the response property "$.status" is 400
Expand Down
Loading