fix: correct OAS schema refs and response body assertions in test definitions - #230
Merged
Merged
Conversation
…initions - Use '#/components/schemas/...' instead of '/components/schemas/...' for OAS schema references in Background x-correlator and scenario steps - Fix CallForwardingSignal inactive scenarios: response body is an array of strings with value [inactive], not a plain string - Fixes camaraproject#228
rartych
requested review from
FabrizioMoggio,
bigludo7 and
chinaunicomyangfan
as code owners
July 24, 2026 18:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Fixes Gherkin test definitions:
retrieveCallForwarding.featurewhere the response body was asserted as a plain string (is a string with the value "inactive") —CallForwardingSignalis an array, so the correct assertion isis an array of strings with the possible values ["inactive"]/components/schemas/...with#/components/schemas/...in allcomplies with the OAS schema atanddoes not comply with the OAS schema atsteps in both feature filesWhich issue(s) this PR fixes:
Fixes #228
Special notes for reviewers:
Scenarios 02 and 03 use the same step definition as scenarios 04/05:
the response body is an array of strings with the possible values [...], which simplifies test implementation.The
#/components/schemas/...form is the correct JSON Pointer / OAS local reference syntax used by the CAMARA test framework.Changelog input