Repository navigation
Conversation
Size Report
Startup median (7 runs, lower is better):
|
There was a problem hiding this comment.
1 issue found across 66 files
You’re at about 95% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="website/docs/docs/browserstack.md">
<violation number="1" location="website/docs/docs/browserstack.md:11">
P1: `plugins add` fetches this package from npm, but `provider-browserstack` remains `private: true` and the release publisher rejects private tarballs, so this PR cannot publish what the guide tells users to install. Gate this instruction until a supported package source is available.</violation>
</file>
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
| ## Install the plugin | ||
|
|
||
| ```bash | ||
| agent-device plugins add @agent-device/browserstack |
There was a problem hiding this comment.
P1: plugins add fetches this package from npm, but provider-browserstack remains private: true and the release publisher rejects private tarballs, so this PR cannot publish what the guide tells users to install. Gate this instruction until a supported package source is available.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At website/docs/docs/browserstack.md, line 11:
<comment>`plugins add` fetches this package from npm, but `provider-browserstack` remains `private: true` and the release publisher rejects private tarballs, so this PR cannot publish what the guide tells users to install. Gate this instruction until a supported package source is available.</comment>
<file context>
@@ -3,7 +3,17 @@ title: BrowserStack
+## Install the plugin
+
+```bash
+agent-device plugins add @agent-device/browserstack
+```
+
</file context>
There was a problem hiding this comment.
This is retained as a publication prerequisite, rather than a temporary code workaround. The maintainer explicitly directed us to keep planned 0.22 install guidance and avoid temporary availability hardening. The package remains private; its placeholder, trusted publisher and usable publication must be verified separately. No claim is made that the package is already available, and the source repair at b41e2fe does not waive that release work.
Apex Sentinel · ✅ ApproveSince the last review: 0 new · 0 still open · 0 no longer raised No open findings. Not in the reviewers' prompt (1 file)
1 new finding away from what changed since 💬 Talking to SentinelIn a finding's thread, reply with:
On this conversation, comment Earlier reviewsReview of
|
| Where | Finding |
|---|---|
packages/provider-browserstack/src/index.ts:3 |
Public options type requires both credential keys the code documents as optional |
Not in the reviewers' prompt (1 file)
pnpm-lock.yaml: generated or a lockfile, so its lines were left out
Reviewed with this repository's own Sentinel configuration (b96eb82b1b2a).
There was a problem hiding this comment.
Apex Sentinel: 1 new finding on 5bc427f. The verdict and the full list are in the summary comment.
|
I found two problems at 5bc427f to fix before merge. The provider scenario suite does not compile on this head. The diff removed the The PR body says the packed-plugin check and the live run were not done. This change is device-facing: lease allocation and session creation now go through the plugin registry instead of the bundled provider list. Nothing yet shows that the bundled dist loads from The open inline threads still apply: private package cannot be published (merging removes bundled support before the package can install), README plugin never passed, and loose smoke server, state directory wording, changeset daemon stop and credentials type, which are lower priority. The publishConfig.exports thread does not apply: Not blocking, take or leave: the factory in provider-browserstack/src/index.ts is a near copy of the TestMu one with the variable names changed, and The Fallow audit and the import-direction check also fail on this head. Fallow reports new exports, dependency and clone findings that overlap the new package and the copied factory. The import-direction check fails on the new provider-browserstack zone. I did not read their full logs, and I did not isolate the Coverage failure. The unused Before merge, please restore the import, clear the Fallow and import-direction failures, and add the packed check and live session evidence. The package also needs to be publishable before or with this merge. There are no conflicts. |
5bc427f to
b41e2fe
Compare
There was a problem hiding this comment.
All reported issues were addressed across 13 files (changes from recent commits).
You’re at about 96% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
|
Thanks for the update. The review of 5bc427f (#4579 (comment)) is partly addressed: the README example, the smoke-test 404 path, and the Repo Guards fails in "Check import-direction DAG" (R11, package-boundaries.test.ts:837): This change is device-facing: BrowserStack lease allocation and session creation now go through the v2 plugin registry and the plugin's tsdown dist, and the bundled provider is removed. The last commits changed the built artifact again (shared build config, a second Not blocking, take or leave: Does this extraction need a new workspace package, a new external dependency (rolldown) and a new layering rank? Could the BrowserStack tsdown config keep the shape of provider-testmu's at the base? If the Fallow clone finding needs a shared owner, could Open threads: the thread on the package staying The large diff stat includes the rebase onto #4578; I reviewed only this PR's own commits. Before merge: declare rolldown 1.2.5 in the root dependency set (or drop build-config from this PR), get Repo Guards and Fallow green, make the package publishable, then post the packed check and the live packed-tarball session. |
…rowserstack plugin Move the BrowserStack provider modules and tests out of provider-webdriver into packages/provider-browserstack, packaged like the TestMu plugin (bundled ESM, type-only agent-device/plugins, ./agent-device export, version 2 factory). provider-webdriver keeps the shared engine and its ./plugin surface. Core no longer registers BrowserStack; connect browserstack without the plugin fails with the existing plugin-not-installed error naming plugins add @agent-device/browserstack. The package stays private until its npm placeholder and trusted publisher exist.
Document plugins add @agent-device/browserstack in the BrowserStack, device cloud and plugins guides, the README and the plugin package README, and add a changeset.
09f643a to
94489a2
Compare
|
The actionable root-range finding is fixed in 589c8d3. Rolldown is used only by an erased type import, so its declaration and lockfile importer now use At that exact clean head, pinned pnpm11.17/Node26.8.1 frozen install and build succeeded. The requested command also exited 0: It packed the current checkout, installed core and plugin in isolated directories, checked the strict export map and absence of core/peer dependencies in the plugin installation, and exercised credential rejection plus connect against the local HTTP fixture. This is packed-contract evidence, not a live BrowserStack session. The checker removes its scratch tarballs after completion; no retained live-artifact provenance is claimed. The rank concern is resolved with its source rationale. The real App Automate session, video/log artifact evidence and placeholder/trusted-publisher prerequisites remain open. No temporary unavailable-package guidance was added. Hosted checks at older heads remain attributed to those heads; fresh CI is pending. |
|
The rolldown R11 fix from the earlier review (09f643a) is now in place. One problem from that review remains at 589c8d3, and the posted evidence is still short of what it needs. The BrowserStack help, docs tell users to run The open review thread on the same point still applies: #4579 (comment) For validation, please post one live BrowserStack App Automate session driven by the packed tarball at the final head. It should show Smoke Tests (ios) and the aggregate Smoke Tests fail on local-simulator Settings navigation. This diff does not touch that path, so they look unrelated, but I had no failure excerpt or base run to confirm. There are no conflicts. Before merge, the package must be publishable (or the hold recorded) and the live session must be posted. |
Summary
Extract BrowserStack into private
@agent-device/browserstackfor #3309. Preserve shared WebDriver behavior. Install withagent-device plugins add @agent-device/browserstackbefore connecting.Head
589c8d3f38f46ed60cd41d0e1fb4ccb5c0fea640targets0.22at2408a3702d487c9bad93776eba5fd71383351e8f, after #4578 merged. Actual layer: 80 files/2142 gross lines; default-main: 419 files/12879 gross, including integration changes.Validation
Earlier b41/854 failed typecheck/Numeric Ranges and R11. The private build-config owner removes the tsdown declaration edge and boundary escapes. Intermediate8f8 omitted project declarations; current root/SDK/consumer references supply them. At 589, type-only Rolldown and its lock importer are devDependencies. Fresh independent source recheck found no actionable repair/interactions findings. Fallow944 passed.
Current iOS smoke failed: attempt1 reached General but Back was unconfirmed; attempts2–3 failed destination waits. Completed trace diagnosis found no proven source cause. Selected-node geometry/ref generation/native hit identity are missing. Apple aggregate propagates this failure. No base-pass or infrastructure waiver exists.
Pinned pnpm11.17/Node26.8.1 frozen install, full-repository format, root and four consumer builds passed. At clean589, the requested packed checker passed: isolated installation, strict exports, typed rejection and fixture-backed CLI connect. Scratch tarballs were removed. Broad local tests/typecheck/lint/gates remain deferred to CI.
Rank thread resolved. Sentinel589 has no visible findings; lockfile and one out-of-diff finding were omitted. Size589 succeeded, with verified digest; this proves Size only.
Real packed BrowserStack/video-log evidence remains open. Keep private:true until placeholder/trusted publisher and usable publication are verified. Planned0.22 guidance stays per maintainer decision.
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.