Skip to content

test(connect): isolate BrowserStack provider scenarios - #4578

Merged
thymikee merged 3 commits into
0.22from
fix/a1-test-isolation-unused-import-20261116
Nov 16, 2026
Merged

thymikee merged 3 commits into
0.22from
fix/a1-test-isolation-unused-import-20261116

Conversation

@thymikee

@thymikee thymikee commented Nov 16, 2026 •

Copy link
Copy Markdown
Member

Summary

Isolate seven BrowserStack connect scenarios into a suite beside the connection owner for #3309. BrowserStack remains bundled in this test-only layer. Preserve the moved test bodies, mocks, host binding and cleanup. Remove the unused remote-state import.

Head e1a244d0e9b9ac9d0ecaa3045ac48ce28331a816, rebased onto current 0.22 572a319cd1b7b4420a68fcd13cbfe3179301c6de. Actual layer: 3 files / 709 gross lines. Default-main: 363 files / 10773 gross, including inherited integration changes.

Validation

Pinned pnpm 11.17 frozen install/root build and full-repository format passed. The relocated test bodies are byte-preserved beyond import paths. The previous lint/typecheck/Numeric Ranges unused-import and R84 placement failures are repaired in source.

Local tests/typecheck/lint/gates remain user-deferred to CI; no canonical receipt is claimed. Independent Codex source review is clear at this head. Hosted checks are complete: 13 successful, one skipped build-cache matrix and one neutral Cubic result; none failed or pending. No live device behavior changes in this layer.

Size succeeded at e1a244d: package bytes are unchanged. Seven-run startup differences remain unexplained; no causal performance clearance is claimed.

Sentinel reports no open visible findings; one below-minor finding is hidden by existing settings. This is not human approval. Test-only preparation is ready for serialized integration; merge waits for the active #4539 worker to finish using the pinned0.22 base. This does not clear #4579 publication/live requirements.


Autofix with [code]smith
Open in [code]smith · Need help on this PR? Tag @codesmith-bot with what you need.

View guided diff Turn on auto-fix

@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Size Report

Metric Base Current Diff
Installed (including dependencies) 6.10 MB 6.10 MB 0 B
Package (unpacked) 6.10 MB 6.10 MB 0 B
Package (download) 1.85 MB 1.85 MB -11 B

Startup median (7 runs, lower is better):

Scenario Base Current Diff
CLI --version 26.9 ms 28.9 ms +1.9 ms
CLI --help 49.8 ms 63.3 ms +13.5 ms

@thymikee
thymikee added this pull request to stack #4580 November 16, 2026 08:40

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

You’re at about 95% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.

View guided diff | Turn on auto-fix | Re-trigger cubic

@apex-sentinel-staging

apex-sentinel-staging Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Apex Sentinel · ✅ Approve

Since the last review: 0 new · 0 still open · 0 no longer raised

No open findings.

1 finding below minor hidden (user_settings.min_severity).

Reviewed with this repository's own Sentinel configuration (ef19edc2a540).

💬 Talking to Sentinel

In a finding's thread, reply with:

Command What it does
@apex-sentinel-staging note <context> Adds context; Sentinel re-checks the cited code
@apex-sentinel-staging pivot <why> Says the finding is wrong; Sentinel re-checks the cited code
@apex-sentinel-staging like Marks the finding as useful
@apex-sentinel-staging dislike <why> Marks it as not useful, so it is not raised again

On this conversation, comment @apex-sentinel-staging review to run a full review once again.

Earlier reviews

Review of f8d3a6e1 · 16.11.2026 08:45 UTC

Apex Sentinel · ✅ Approve

No open findings.

1 finding below minor hidden (user_settings.min_severity).

Reviewed with this repository's own Sentinel configuration (b96eb82b1b2a).

@thymikee

Copy link
Copy Markdown
Member Author

This PR is ready from the code side at f8d3a6e. The scenarios moved intact into the BrowserStack test file, and I found no problems. Not blocking: readRemoteConnectionState is still imported in cloud-connect-profile.test.ts, but its only use moved out, so the Lint job likely flags it. Please delete it from that import and run pnpm lint for any other unused symbols; take it or leave it. Lint, Typecheck & Package, Repo Guards and Numeric Ranges are failing on this head. Lint probably comes from that import. Repo Guards and Numeric Ranges run nothing this test-only diff touches, so they may fail on base too. Please check that before merge, and get the failing jobs green on the new head.

@thymikee thymikee added the ready-for-human Valid work that needs human implementation, judgment, or maintainer merge label Nov 16, 2026
…test file

Give the BrowserStack connect cases their own file beside cloud-connect-testmu.test.ts, split from the cloud-profile and profile-field tests. Behavior and assertions stay the same, so the BrowserStack provider extraction can change one provider-owned file instead of the shared connect tests.
@thymikee
thymikee force-pushed the fix/a1-test-isolation-unused-import-20261116 branch from f8d3a6e to e1a244d Compare November 16, 2026 10:02
@thymikee

Copy link
Copy Markdown
Member Author

The code at e1a244d looks good to me. It still touches 3 files and no production lines, and I found no problems.

Since the earlier review at f8d3a6e, the Lint failure from the unused import is fixed, and all 15 checks now pass. There are no conflicts. Nothing else is needed before merge.

@thymikee
thymikee merged commit 2408a37 into 0.22 Nov 16, 2026
15 checks passed
@thymikee
thymikee deleted the fix/a1-test-isolation-unused-import-20261116 branch November 16, 2026 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-human Valid work that needs human implementation, judgment, or maintainer merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant