Repository navigation
test(connect): isolate BrowserStack provider scenarios - #4578
Conversation
Size Report
Startup median (7 runs, lower is better):
|
There was a problem hiding this comment.
No issues found across 3 files
You’re at about 95% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.
Apex Sentinel · ✅ ApproveSince the last review: 0 new · 0 still open · 0 no longer raised No open findings. 1 finding below 💬 Talking to SentinelIn a finding's thread, reply with:
On this conversation, comment Earlier reviewsReview of
|
|
This PR is ready from the code side at f8d3a6e. The scenarios moved intact into the BrowserStack test file, and I found no problems. Not blocking: |
…test file Give the BrowserStack connect cases their own file beside cloud-connect-testmu.test.ts, split from the cloud-profile and profile-field tests. Behavior and assertions stay the same, so the BrowserStack provider extraction can change one provider-owned file instead of the shared connect tests.
f8d3a6e to
e1a244d
Compare
Summary
Isolate seven BrowserStack connect scenarios into a suite beside the connection owner for #3309. BrowserStack remains bundled in this test-only layer. Preserve the moved test bodies, mocks, host binding and cleanup. Remove the unused remote-state import.
Head
e1a244d0e9b9ac9d0ecaa3045ac48ce28331a816, rebased onto current 0.22572a319cd1b7b4420a68fcd13cbfe3179301c6de. Actual layer: 3 files / 709 gross lines. Default-main: 363 files / 10773 gross, including inherited integration changes.Validation
Pinned pnpm 11.17 frozen install/root build and full-repository format passed. The relocated test bodies are byte-preserved beyond import paths. The previous lint/typecheck/Numeric Ranges unused-import and R84 placement failures are repaired in source.
Local tests/typecheck/lint/gates remain user-deferred to CI; no canonical receipt is claimed. Independent Codex source review is clear at this head. Hosted checks are complete: 13 successful, one skipped build-cache matrix and one neutral Cubic result; none failed or pending. No live device behavior changes in this layer.
Size succeeded at e1a244d: package bytes are unchanged. Seven-run startup differences remain unexplained; no causal performance clearance is claimed.
Sentinel reports no open visible findings; one below-minor finding is hidden by existing settings. This is not human approval. Test-only preparation is ready for serialized integration; merge waits for the active #4539 worker to finish using the pinned0.22 base. This does not clear #4579 publication/live requirements.
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.