Repository navigation
fix(open): wait for the launched app's first screen before the first capture #4513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
thymikee
wants to merge
17
commits into
main
Choose a base branch
from
fix/open-waits-for-first-screen
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+741
−101
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
6f4b568
fix(open): wait for the launched app's first screen before the first …
thymikee 0d6b36d
refactor(capture-kit): keep the first-screen readiness rule module-pr…
thymikee 61c230a
fix(open): keep the first-screen wait on iOS and settle fixtures on a…
thymikee efe4405
fix(open): qualify the first-screen wait by the launch observation; p…
thymikee 1f137b4
style: format the parity fixture rows
thymikee a4a8036
fix(open): never accept a root-only tree as the first screen; an open…
thymikee 093d6ee
docs(open): name both timeout outcomes of the first-screen wait
thymikee eea1539
fix(open): report loading only for a launch tree with no content
thymikee 8638f3e
fix(open): judge a first screen at the deadline by the same readiness…
thymikee d6a0872
docs(open): limit the first-screen wait promise to local iOS simulators
thymikee 61f5873
refactor(selectors): split the zero-match absence branch out of class…
thymikee 7872ffd
docs(open): describe the post-open wait as the first-screen wait on e…
thymikee 882598e
Merge origin/main into fix/open-waits-for-first-screen
thymikee 896ab43
fix(capture): tell a first screen from a splash by its readable content
thymikee d67b371
test(daemon): name the splash wait test for its bounded behavior
thymikee 885078f
Merge remote-tracking branch 'origin/main' into HEAD
thymikee 72afa34
fix(mcp): keep the first-screen wait out of the always-loaded open sc…
thymikee File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.