Repository navigation
Conversation
Size Report
Startup median (7 runs, lower is better):
|
There was a problem hiding this comment.
All reported issues were addressed across 21 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
…capture The post-open stabilization accepted any quiet pair, so a React Native launch or loading tree (only the Application root) settled at once and open --foreground returned a 1-node snapshot. Every iOS and Android app launch now marks a first-screen wait: a content-free tree never settles, a sparse tree settles after 1.5s unchanged, and a 10s budget ends in a typed postGestureOutcome.kind 'loading' with a warning. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ivate Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Apex Sentinel · ✅ ApproveSince the last review: 0 new · 0 still open · 0 no longer raised No open findings. 1 new finding away from what changed since 💬 Talking to SentinelIn a finding's thread, reply with:
On this conversation, comment Earlier reviewsReview of
|
| Where | Finding |
|---|---|
website/docs/docs/commands.md:114 |
🆕 commands.md still says only a non-"observable" open arms the wait, and that it is brief |
1 finding below minor hidden (user_settings.min_severity).
1 new finding away from what changed since 8638f3e not shown. Comment @apex-sentinel-staging review for a full review.
Reviewed with this repository's own Sentinel configuration (ddbfc855661f).
Review of 8638f3e6 · 13.11.2026 21:54 UTC
Apex Sentinel · ✅ Approve
Since the last review: 0 new · 0 still open · 1 no longer raised (1 marked fixed)
No open findings.
1 finding below minor hidden (user_settings.min_severity).
1 new finding away from what changed since eea1539 not shown. Comment @apex-sentinel-staging review for a full review.
Reviewed with this repository's own Sentinel configuration (ddbfc855661f).
Review of eea1539b · 13.11.2026 21:44 UTC
Apex Sentinel · ✅ Approve
Since the last review: 1 new · 0 still open · 1 no longer raised (1 marked fixed)
1 finding(s): 1 minor.
🟡 Minor (1)
| Where | Finding |
|---|---|
packages/capture-kit/src/post-gesture-stability.ts:341 |
🆕 A sparse tree that quiets only at the 10s deadline is returned as a settled first screen |
Reviewed with this repository's own Sentinel configuration (ddbfc855661f).
Review of a4a80367 · 13.11.2026 21:31 UTC
Apex Sentinel · ✅ Approve
Since the last review: 1 new · 0 still open · 3 no longer raised (1 marked fixed)
1 finding(s): 1 minor.
🟡 Minor (1)
| Where | Finding |
|---|---|
packages/capture-kit/src/post-gesture-stability.ts:341 |
🆕 Timeout on a sparse-but-changing launch tree is reported as 'loading', not 'unsettled' |
Reviewed with this repository's own Sentinel configuration (ddbfc855661f).
Review of 61c230a0 · 13.11.2026 21:13 UTC
Apex Sentinel · ✅ Approve
Since the last review: 3 new · 0 still open · 0 no longer raised
3 finding(s): 3 minor.
🟡 Minor (3)
| Where | Finding |
|---|---|
packages/daemon/src/core/deferred-interaction-outcome.ts:236 |
🆕 An open now erases a scroll's owed stabilization, dropping its baseline checks |
packages/daemon/src/core/deferred-interaction-outcome.ts:403 |
🆕 Sparse-marked launch tree is accepted as the first screen on one quiet pair |
packages/daemon/src/core/deferred-interaction-outcome.ts:403 |
🆕 Legacy sparse capture (Application root only, no snapshotQuality) waits the full 10s |
Reviewed with this repository's own Sentinel configuration (ddbfc855661f).
Review of f9ee613a · 13.11.2026 20:49 UTC
Apex Sentinel · ✅ Approve
No open findings.
1 finding below minor hidden (user_settings.min_severity).
Reviewed with this repository's own Sentinel configuration (ddbfc855661f).
|
I reviewed f9ee613. The iOS change looks right, but this PR also changes Android launch behavior and has no Android evidence yet. The PR removes the Please run The open inline threads on Android root counting (r4568478849) and the sparse-read exception missing from the help text (r4568478841) still apply, as does the exhaustiveness check on the outcome kinds (r4568478812). The five lower-priority threads still apply too, so none of them can be resolved yet. Not blocking, take or leave: Coverage is failing. The PR adds production lines without direct tests ( |
… first screen Restore the Apple-only gate on markPostOpenStabilization: Android trees carry no Application/Window root, so the content count cannot tell a launch surface from a first screen there. Move the content count into the daemon so capture-kit's import closure stays unchanged. Classify a miss on a loading tree as its own absence observation, tie the outcome-kind table to the union, state the sparse-read exception and the polling budget in help and docs, and give the post-open reads in the provider and contract scenarios a populated first screen. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
f9ee613 to
61c230a
Compare
|
Re the Chief of Staff review. I chose (b): the Apple-only gate is restored at 61c230a. Android. Android trees carry no Application/Window root node, so a root-based content count cannot separate a launch or decor-only tree from a first screen. A credible fix needs a new Android structural-root rule, and that rule needs its own design and emulator measurements. Inline threads. All 8 are fixed, answered and resolved:
Coverage job. The failure was not changed-line coverage. 76 tests failed:
Locally, interaction-contract, provider-integration and the touched unit suites pass. Non-blocking.
|
There was a problem hiding this comment.
All reported issues were addressed across 29 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
There was a problem hiding this comment.
Apex Sentinel: 3 new findings on 61c230a. The verdict and the full list are in the summary comment.
…arent fixture rows on the app root Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… supersedes owed stabilization A root-only tree is a launch or loading surface whatever quality verdict the producer gave it: the iOS runner marks exactly that tree sparse, and a runner that predates verdicts publishes it with none. Count content beyond the roots instead of trusting the sparse verdict. State why an open replaces a scroll's owed stabilization. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
All reported issues were addressed across 6 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
There was a problem hiding this comment.
Apex Sentinel: 1 new finding on a4a8036. The verdict and the full list are in the summary comment.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A small first screen that keeps changing through the budget is unsettled, as the docs say; loading means nothing beyond the app roots. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
All reported issues were addressed across 2 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
There was a problem hiding this comment.
Apex Sentinel: 1 new finding on eea1539. The verdict and the full list are in the summary comment.
… rule A small tree whose last pair agrees just before the budget ends has not held the 1.5 s quiet window, so it is unsettled, not settled. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Thanks for the fixes since f9ee613. At 8638f3e the root-only tree, the Android arm, the timeout classification and the test gaps are fixed, and all 22 checks pass (the earlier Coverage failure was fixed in 61c230a). One docs problem remains, and there are no conflicts. The help says the first-screen wait applies "On iOS", and commands.md says it runs where "local simulators and devices do". But the only Apple writer of Not blocking, and fine to take or leave: The open inline thread on the physical-device qualifier (#4513 (comment)) still applies and is the same point as above. These threads no longer apply and can be resolved: #4513 (comment) (superseding an owed scroll record on open is deliberate and documented at deferred-interaction-outcome.ts:232-235), and #4513 (comment) (a legacy root-only tree reporting loading after 10 s is the documented outcome). The other open threads are fixed at this head. I did not reproduce the iOS simulator runs in the PR body; eea1539 and 8638f3e change only the timeout classification, not the success route those runs used, so I accepted the earlier evidence for this delta. I could not run the test suites, so the deadline test's validity comes from reading the eea1539 code. I also did not check whether a remote iOS provider supplies a launch observation port with |
Only a local iOS simulator reports the post-open observation that arms the wait; physical devices and other backends skip it. Absence classification now maps every post-gesture outcome kind, so a new rest-unproven kind is a compile error rather than a silent absent. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Fixed in d6a0872: every sentence that promises the first-screen wait now names the condition the code checks — a local iOS simulator (the only Apple writer of Non-blocking note taken: The inline threads you listed (r4568712653, r4568723351, r4568723372) are resolved; I added a follow-up reply on r4568712653 with the narrowed wording. Unit tests (2,441), typecheck and format check pass locally. |
…ifyAbsenceObservation Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Apex Sentinel: 1 new finding on 61f5873. The verdict and the full list are in the summary comment.
…very reported observation Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
This PR is ready at 7872ffd. The delta fixes the docs finding from the earlier review: the physical-device qualifier is now in all four sites (commands.md:101, app.ts:46, flag-definitions-action.ts:416, client-app.ts:93-99), and the iOS Simulator bullet at commands.md:114 now matches the code. All 22 checks pass at this head, and there are no conflicts. Not blocking: commands.md:101 and app.ts:46 say "backends that report no post-open observation skip the wait", but Android reports one and still skips the wait because On the earlier inline threads, these no longer apply and can be resolved: the Simulator launch-behavior wording is fixed at commands.md:114 (#4513 (comment)), the physical-device qualifier is fixed (#4513 (comment)), superseding an owed scroll record on open is deliberate and documented (#4513 (comment)), and a legacy root-only tree reporting loading after 10s is the documented outcome (#4513 (comment)). No other threads remain open. I read the code and docs at this head but did not run the test suites or re-run the simulator validation in the PR body. The delta changes help text and a behavior-preserving selectors refactor, not iOS logic. The claim that the client-app.ts doc comment matches the flag description rests on green CI, not on me running that test. I also did not check remote or provider iOS backends for other paths that report a post-open observation. |
|
At 7872ffd this branch now conflicts with |
Resolves the open summary conflict with #4507: keeps main's agent guidance and adds the local-iOS-simulator first-screen wait, compact enough to keep the always-loaded tools inside their 22 KB budget. Takes the review note that other devices and backends (Android included) skip the wait. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Brought up to date with main in 882598e (merged main rather than rebasing: the branch has ~20 commits that touch the same
|
|
I re-reviewed 882598e after the merge. The earlier conflict is resolved, the readiness logic is unchanged, the compacted help matches the code, and I found no problems. There are no conflicts, and all 22 checks pass at this commit. Both open threads are fixed at this head, so please resolve them. The device qualifier thread (#4513 (comment)) stays fixed after the merge: app.ts:46 and commands.md:101 say other devices and backends skip the wait, and flag-definitions-action.ts:416 and client-app.ts:93-97 scope the promise to a local iOS simulator. The stabilization wording thread (#4513 (comment)) is also fixed: commands.md:114 is unchanged by the merge and matches markPostOpenStabilization in deferred-interaction-outcome.ts:240-253. I did not measure the 22 KB always-loaded MCP budget myself and rely on green CI for it. I also took from the previous review that the local iOS simulator is the only producer of postOpenObservation that reaches the marker in open-policy.ts. Production code is unchanged in this delta, so I did not re-read it. Nothing else needs to happen before merge. |
Measured on Bluesky, the storyboard splash is one unlabeled full-screen image that held unchanged for 1.2-1.9 s after open returned, so the "sparse tree quiet for 1.5 s" rule could return the splash as the first screen. A first screen now needs an element besides the app roots with a label or value that is not a busy indicator. The node threshold and the quiet window are gone: a one-button screen is ready on its first quiet pair, and a splash never is. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
All reported issues were addressed across 6 files (changes from recent commits).
You’re at about 96% of the monthly reviewed-line limit. You may want to disable incremental reviews to conserve quota. Reviews will continue until that limit is exceeded. If you need help avoiding interruptions, please contact contact@cubic.dev.
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* origin/main: fix(alert): derive the request envelope from an alert wait window (#4581) fix(android): require a nonzero chunk before a recorder counts as ready (#4559) chore(deps): clear astro and node-forge security alerts (#4577) fix(ios): establish the screen origin of a full-screen private AX root (#4573) docs(agents): trace behavior claims during review (#4576) fix(mcp): trim the press plan text back under the always-loaded byte budget (#4572) refactor(alert): one helper owns the alert runner budget (#4563) feat(interaction): multi-ref press plan lowered through the ordinary press lane (#4296) fix(ios): use the caller's budget for alert get and type the watchdog outcome (#4540) feat(recovery): bound remote health and runner-busy recovery by the command's deadline (#4541) fix(ios): find the navigation bar back button outside the bar's subtree (#4542) feat(open): report device kind, model and osVersion on open and session identity (#4543) fix(apple): use typed screenshot timeouts and observed shutdown recovery (#4544) feat(device-status): report per device whether a new session can take it (#4547) fix(runner): type the refusals for a control the target cannot supply (#4548) refactor(transport): share outgoing transfer phase ownership (#4551) fix(remote): bound artifact preparation and upload phases (#4552)
…hema Merged with main, the always-loaded tools were 433 bytes over the 22 KB budget. The open summary and the foreground input text return to their main wording; the CLI usage line and the docs keep the 10s wait, and a timed-out wait still carries its own warning in the response. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The MCP budget concern from the earlier review is fixed at 72afa34, and all 22 checks pass, including the always-loaded MCP budget. One thing remains before merge: the changed open route has no live run at the new readiness rule. There are no conflicts. 896ab43 replaces the readiness rule for the next capture after Not blocking, take or leave: in a React Native dev build a stable loading text, such as the Metro "Loading from ..." banner, is a labeled non-root StaticText, so showsFirstScreen would accept it on the first agreeing pair 200 ms apart, where the old rule held a tree of 4 or fewer nodes for 1.5 s. Whether the banner window reaches the XCTest app snapshot is unproven, so the dev-build run above can settle this; if a banner-only snapshot shows up, the rule is that a first screen needs labeled content outside transient loading surfaces, enforced in The thread about the splash-image test name is fixed at d67b371, so it can be resolved: #4513 (comment). |
|
Live evidence for head 72afa34, as requested in #4513 (comment):
I rewrote the Validation section with these results and removed the outdated "iOS logic unchanged since" line. No code changed, so the head is still 72afa34, with 22/22 checks green. |
Summary
On iOS, the first capture after
openlaunches an app now waits for the app's first screen. This includes theopen --foregroundinitial snapshot. Before this change, a React Native launch tree that held only the Application root settled on its first quiet pair, soopen --relaunch --foregroundreturned a 1-node snapshot.Rule (loop in
post-gesture-stability.ts, predicateshowsFirstScreenindeferred-interaction-outcome.ts, armed bymarkPostOpenStabilizationon Apple only):Image, and it held unchanged for 1.2–1.9 s afteropenreturned. The empty React Native root that follows is one unlabeled view.openwithsettle: false) is a follow-up.postGestureOutcome: {kind: "loading"}and a warning.is/wait absentreportsobservation: "loading".Help and docs: the
open --foregroundCLI usage line andwebsite/docs/docs/commands.mddescribe the wait. The always-loaded MCPopenschema keeps itsmainwording, because it is within bytes of the 22 KB budget. An agent learns of a timed-out wait from the warning in the response.observableopens arm the wait too. The open record replaces any stabilization or moving-target baseline an earlier action still owed: the open replaced that screen, so a verdict against it would charge the open to the earlier action. Android stays unchanged: its trees have no root node, so the content rule needs its own design.Validation
Live run on head 72afa34 (readiness rule from 896ab43, budget fix 72afa34). iPhone 17 Pro sim (iOS 27.0), Agent Device Tester Debug dev build, Metro (
expo start --dev-client) serving on 8081. The run used this branch's CLI (pnpm build,bin/agent-device.mjs) with its own--state-dir. Command:open com.callstack.agentdevicelab --relaunch --foreground --metro-port 8081 --json. Host load average was 90–128 during the runs.postGestureOutcomeAll 7 relaunches returned the full home tree. The home screen has grown since the earlier run, so it is now 52 interactive nodes, not about 30. No run returned a Metro loading banner or a root-only tree. The first open, before Metro connected, returned the dev launcher (
Development Build,DEVELOPMENT SERVERS). That is the dev client's own screen, not a loading surface.Read-by-read trace of the same relaunch with the pre-PR CLI (0.21.36):
openreturned while the tree was root-only. That phase lasted about 1.3 s, and then the tree went 41 → 88 nodes (still changing) → the same 88 nodes twice. No read held a banner node. The Metro banner does not appear in the app's accessibility tree, soshowsFirstScreenneeds no banner rule.Readiness rule change (896ab43): Bluesky Release build, iOS 27.0 sim, 4 launches traced read by read. The new predicate rejected every splash and empty-root read and accepted only the home screen. Tester Release, FlappyMorse (a game with labeled elements), and native Settings, Contacts, Calendar, Maps, Photos, Files, Reminders, Health and Safari show labeled trees by the time
openreturns.Earlier runs (before 896ab43, under the replaced sparse-tree rule): base 80075b6
--relaunchreturned 1 node 10/10 (about 2.7 s). The previous rule returned 30 nodes 0/22 sparse (3.5–9.5 s, median about 4.5 s). Warm open went from a 625 ms median to 1004 ms (n=15). These no longer describe the current iOS logic. The live run above replaces them.CI owns the full suite. Locally, with main merged: typecheck, format, the MCP budget test, and the touched capture-kit, daemon, command-surface and MCP suites passed.
Risks: providers that report no
postOpenObservationdo not arm the wait. An app whose tree stays root-only (empty UI or accessibility unavailable) waits the full 10s and reportsloading.🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.