Skip to content

docs(selectors): document isNodeEditable's rule for integrators - #3574

Merged
thymikee merged 1 commit into
mainfrom
docs/is-node-editable-public-doc
Oct 13, 2026
Merged

thymikee merged 1 commit into
mainfrom
docs/is-node-editable-public-doc

Conversation

@thymikee

@thymikee thymikee commented Oct 13, 2026 •

Copy link
Copy Markdown
Member

Summary

Follow-up to #3566, from its review: isNodeEditable is published from agent-device/selectors (website/docs/docs/build-an-integration.md:67), so its declaration should state the rule integrators get. The new doc comment gives the full precedence:

  • a disabled node is not editable;
  • otherwise the published editable fact decides;
  • the platform type decides only when the snapshot carries no such fact.

One file, documentation only.

Validation

pnpm check:affected --run passed on 5664448aa. Comment-only change; no runtime validation applies.

🤖 Generated with Claude Code

View guided diff Turn on auto-fix

isNodeEditable is published from agent-device/selectors, and #3566 removed
the only place its declaration stated the rule. The doc comment now gives
the full precedence: a disabled node is not editable, then the published
editable fact, then the platform type.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

View guided diff | Turn on auto-fix | Re-trigger cubic

@thymikee

Copy link
Copy Markdown
Member Author

This looks good at 5664448. It adds a 4-line doc comment to isNodeEditable in packages/selectors/src/internal/node.ts and changes no runtime code.

Many CI jobs are failing, including CodeQL and the Smoke jobs. A comment-only change cannot reach any of those routes, so the failures most likely come from infrastructure. I did not read the CI logs. I also did not check whether the comment appears in the published typings for @agent-device/selectors. Please re-run CI before merge.

There are no conflicts.

@thymikee thymikee added the ready-for-human Valid work that needs human implementation, judgment, or maintainer merge label Oct 13, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Size Report

Metric Base Current Diff
Installed (including dependencies) 5.18 MB 5.18 MB +172 B
Package (unpacked) 5.18 MB 5.18 MB +172 B
Package (download) 1.56 MB 1.56 MB +65 B

Startup median (7 runs, lower is better):

Scenario Base Current Diff
CLI --version 23.6 ms 22.8 ms -0.8 ms
CLI --help 62.4 ms 62.2 ms -0.2 ms

@thymikee
thymikee merged commit 44e2969 into main Oct 13, 2026
19 checks passed
@thymikee
thymikee deleted the docs/is-node-editable-public-doc branch October 13, 2026 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-human Valid work that needs human implementation, judgment, or maintainer merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant