Repository navigation
docs(selectors): document isNodeEditable's rule for integrators - #3574
Merged
Merged
Conversation
isNodeEditable is published from agent-device/selectors, and #3566 removed the only place its declaration stated the rule. The doc comment now gives the full precedence: a disabled node is not editable, then the published editable fact, then the platform type. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
This looks good at 5664448. It adds a 4-line doc comment to Many CI jobs are failing, including CodeQL and the Smoke jobs. A comment-only change cannot reach any of those routes, so the failures most likely come from infrastructure. I did not read the CI logs. I also did not check whether the comment appears in the published typings for There are no conflicts. |
Contributor
Size Report
Startup median (7 runs, lower is better):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #3566, from its review:
isNodeEditableis published fromagent-device/selectors(website/docs/docs/build-an-integration.md:67), so its declaration should state the rule integrators get. The new doc comment gives the full precedence:editablefact decides;One file, documentation only.
Validation
pnpm check:affected --runpassed on5664448aa. Comment-only change; no runtime validation applies.🤖 Generated with Claude Code