Repository navigation
refactor(selectors): drop the narrating comment on isNodeEditable - #3566
Conversation
The comment restated the fallback and overstated the precedence: a disabled node is refused before the editable fact is read. The selectors docs state the rule. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Size Report
Startup median (7 runs, lower is better):
|
|
This PR is ready at 4832285. All 19 checks are green. I did not run tests, and a comment deletion cannot change behavior. Not blocking: |
|
|
Took it: #3574 puts a public doc comment back on |
isNodeEditable is published from agent-device/selectors, and #3566 removed the only place its declaration stated the rule. The doc comment now gives the full precedence: a disabled node is not editable, then the published editable fact, then the platform type. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Summary
Follow-up to #3535's open review thread: the doc comment on
isNodeEditablerestated the??fallback and overstated the precedence (a disabled node is refused before theeditablefact is read). The rule is already documented inwebsite/docs/docs/selectors.md, so the comment goes. One file, one deleted line, no behavior change.Validation
pnpm check:affected --runpassed on483228505. Comment-only change; no runtime validation applies.🤖 Generated with Claude Code