Skip to content

refactor(selectors): drop the narrating comment on isNodeEditable - #3566

Merged
thymikee merged 1 commit into
mainfrom
docs/editable-fact-comment
Oct 13, 2026
Merged

thymikee merged 1 commit into
mainfrom
docs/editable-fact-comment

Conversation

@thymikee

@thymikee thymikee commented Oct 13, 2026 •

Copy link
Copy Markdown
Member

Summary

Follow-up to #3535's open review thread: the doc comment on isNodeEditable restated the ?? fallback and overstated the precedence (a disabled node is refused before the editable fact is read). The rule is already documented in website/docs/docs/selectors.md, so the comment goes. One file, one deleted line, no behavior change.

Validation

pnpm check:affected --run passed on 483228505. Comment-only change; no runtime validation applies.

🤖 Generated with Claude Code

View guided diff Turn on auto-fix

The comment restated the fallback and overstated the precedence: a disabled
node is refused before the editable fact is read. The selectors docs state
the rule.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

View guided diff | Turn on auto-fix | Re-trigger cubic

@github-actions

Copy link
Copy Markdown
Contributor

Size Report

Metric Base Current Diff
Installed (including dependencies) 5.18 MB 5.18 MB -101 B
Package (unpacked) 5.18 MB 5.18 MB -101 B
Package (download) 1.56 MB 1.56 MB -51 B

Startup median (7 runs, lower is better):

Scenario Base Current Diff
CLI --version 21.0 ms 21.1 ms +0.2 ms
CLI --help 58.8 ms 58.9 ms +0.2 ms

@thymikee

Copy link
Copy Markdown
Member Author

This PR is ready at 4832285. All 19 checks are green. I did not run tests, and a comment deletion cannot change behavior.

Not blocking: isNodeEditable is part of the published agent-device/selectors entry and is documented in build-an-integration.md:67, so the removed JSDoc was the only place integrators could see that a published editable fact overrides type inference. You could keep a short public doc comment there, for example "False for disabled nodes; otherwise a published editable fact decides, and the platform type decides only when the fact is absent." Or state that rule next to the doc entry. Take it or leave it.

@thymikee thymikee added the ready-for-human Valid work that needs human implementation, judgment, or maintainer merge label Oct 13, 2026
@thymikee
thymikee merged commit 3c0599c into main Oct 13, 2026
19 checks passed
@thymikee
thymikee deleted the docs/editable-fact-comment branch October 13, 2026 07:44
@github-actions

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-10-13 07:45 UTC

@thymikee

Copy link
Copy Markdown
Member Author

Took it: #3574 puts a public doc comment back on isNodeEditable with the full rule (disabled first, then the published editable fact, then the platform type).

thymikee added a commit that referenced this pull request Oct 13, 2026
isNodeEditable is published from agent-device/selectors, and #3566 removed
the only place its declaration stated the rule. The doc comment now gives
the full precedence: a disabled node is not editable, then the published
editable fact, then the platform type.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-human Valid work that needs human implementation, judgment, or maintainer merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant