Repository navigation
fix(selectors): honor a published editable fact in matching and is editable - #3535
Conversation
…itable Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
|
There was a problem hiding this comment.
All reported issues were addressed across 5 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
Size Report
Startup median (7 runs, lower is better):
|
|
This PR is ready at 60eb25c. Honoring a published editable fact in matching and in The cubic-dev-ai P3 thread on the same comment still applies, and it is only about wording: #3535 (comment) The Contacts Mobile Spinner table on Android (android-helper 0.21.27-dev) is your own live evidence. I did not reproduce it, and I did not run the tests. I also did not check whether the helper publishes editable=false for any EditText that used to match by type. Those nodes now stop matching |
Summary
isNodeEditablenow lets an expliciteditablefact decide botheditable=selector matching andis editable. Without the fact, type inference is unchanged; a disabled node is still never editable. Fix is in the one owner (packages/selectors/src/internal/node.ts), plus a note inwebsite/docs/docs/selectors.md. 5 files touched, no scope expansion.Closes #3530
Validation
Tested commit: 60eb25c.
pnpm check:affected --runpassed.New unit tests cover a custom view with
editable: true, a text field witheditable: false, a disabled field, and the fact absent. The three fact-driven tests fail onorigin/main'snode.tsand pass with the fix.Live, Android emulator via ADB (android-helper backend 0.21.27-dev), Contacts "Create contact" screen, whose "Mobile" Spinner publishes
editable: true:is editable 'label="Mobile"'COMMAND_FAILED ... editable:falsePassed: is editableis exists 'label="Mobile" editable=true'Passedis exists 'label="Mobile" editable=false'PassedKnown gap, outside this package:
fill's "not a text input" warning insrc/commands/interaction/runtime/interactions.tsstill usesisFillableType, not the fact.🤖 Generated with Claude Code