Conversation
🔍 PR Link Analysis🔗 Ranked Links#1 these Wayland patches🔍 The PR's refactor to replace #2 going away🔍 The PR aims to enable Wayland support by replacing USE_X11 with OS_LINUX, as Wayland offers better rendering performance than X11 on Linux, especially for embedded devices. #3 commit guidelines🔍 This change replaces #4 https://github.com/electron/electron/blob/master/CONTRIBUTING.md🔍 This pull request replaces USE_X11 with OS_LINUX to enable code sharing with Ozone, aligning with Electron's release cadence of maintaining its three latest major versions with a new major version every 8 weeks. #5 chromium#1085700🔍 This change replaces #6 these chromium changes🔍 The change replaces USE_X11 with OS_LINUX to enable code sharing across different Linux windowing systems like X11 and Wayland. |
Description of Change
This pull-request is a small first step in trying to bring support for Wayland to Electron. I'm planning to follow up on this with more pull-requests in an effort to upstream these Wayland patches.
However, those patches will need some adjustments in order to make them compatible with the upcoming Chromium changes (chromium#1085700) which will soon be merged into Electron (#25488). In particular, it should be taken into consideration that the
USE_X11andUSE_OZONEbuild flags are no longer mutually exclusive.Also,
USE_X11is going away so it might be desirable as a long term goal to remove it from Electron too and replace it with the Ozone equivalents.With that in mind, this pull-request replaces a few instances of
#if defined(USE_X11)with#if defined(OS_LINUX)where it was identified that the guarded code could be shared with Ozone.The more meaningful changes will come in the upcoming pull-requests but I'll be waiting for these chromium changes to be pulled into Electron first (#24984, #25488).
Checklist
npm testpassesRelease Notes
Notes: none