Skip to content

refactor: replace USE_X11 with OS_LINUX for sharing code with Ozone#17

Closed
chatpongs wants to merge 1 commit intomainfrom
pull/25522
Closed

refactor: replace USE_X11 with OS_LINUX for sharing code with Ozone#17
chatpongs wants to merge 1 commit intomainfrom
pull/25522

Conversation

@chatpongs
Copy link
Copy Markdown

Description of Change

This pull-request is a small first step in trying to bring support for Wayland to Electron. I'm planning to follow up on this with more pull-requests in an effort to upstream these Wayland patches.

However, those patches will need some adjustments in order to make them compatible with the upcoming Chromium changes (chromium#1085700) which will soon be merged into Electron (#25488). In particular, it should be taken into consideration that the USE_X11 and USE_OZONE build flags are no longer mutually exclusive.

Also, USE_X11 is going away so it might be desirable as a long term goal to remove it from Electron too and replace it with the Ozone equivalents.

With that in mind, this pull-request replaces a few instances of #if defined(USE_X11) with #if defined(OS_LINUX) where it was identified that the guarded code could be shared with Ozone.

The more meaningful changes will come in the upcoming pull-requests but I'll be waiting for these chromium changes to be pulled into Electron first (#24984, #25488).

Checklist

Release Notes

Notes: none

@MonnetalX
Copy link
Copy Markdown

🔍 PR Link Analysis

🔗 Ranked Links

#1 these Wayland patches

🔍 The PR's refactor to replace USE_X11 with OS_LINUX is a foundational step for enabling Wayland support by decoupling X11-specific code from broader Linux platform logic.

#2 going away

🔍 Electron currently lacks prebuilt binaries for Wayland, which limits performance on embedded devices where Wayland is the default display server.

#3 commit guidelines

🔍 This change replaces USE_X11 with OS_LINUX to allow code sharing between X11 and Ozone backends, aligning with the broader effort to support Wayland.

#4 https://github.com/electron/electron/blob/master/CONTRIBUTING.md

🔍 This change aligns with Electron's policy of maintaining its three latest major versions, each released every 8 weeks, ensuring compatibility and support.

#5 chromium#1085700

🔍 This change replaces USE_X11 with OS_LINUX to allow sharing code between X11 and Wayland backends in Ozone.

#6 these chromium changes

🔍 The change replaces USE_X11 with OS_LINUX to enable code sharing across different Linux windowing systems, including Wayland.

@c4rtune c4rtune closed this Apr 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants