Repository navigation
feat(engine): fileSignals op for data-flow metrics, findings and work packets - #398
Merged
Merged
Conversation
… packets One tier-2 op builds the legacy report once and returns per-file metrics, impossible-defense and repeated-fork findings, and dataflow.md (the old CLI's work-packets, defensive-ledger, repeated-forks, prop-relay, context-relay and fan-out views). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 21, 2026
byronwall
marked this pull request as ready for review
November 21, 2026 14:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The data-flow engine can now produce tsx-data-flow's reporting for srcly: per-file data-flow metrics, two finding rules (
impossible-defenseandrepeated-fork), and the old CLI's work packets as onedataflow.md. This layer adds the engine op; #399 makessrcly report --dataflowuse it.What you'll see
fileSignalsop builds the legacy render-path report once (tier 2) and returns:impossible-defensefinding per type-impossible??or?., in the file that holds it, and onerepeated-forkfinding per component that tests the same discriminant at several sibling branch sites (Solid<Show>and<Match>too);dataflow.md: the old CLI's work-packets, defensive-ledger, repeated-forks, prop-relay, context-relay and fan-out views, 8 items each, with srcly's provenance and rerun line.Proof
Each
dataflow.mdsection matches the archived tsx-data-flow CLI byte for byte. I rantsx-dataflow --root examples/bad-ish-solid --view <view> --max-items 8in~/Projects/tsx-data-flow(archived,93a9052) and compared it with the op's output onengine/examples/bad-ish-solid(dates and the provenance/footer lines that name the tool aside):The findings on the same example, from
engine/test/srcly/file-signals.test.ts:These are the same 12 impossible guards as the old defensive ledger, and the same fork as its repeated-forks view.
scripts/check.shpasses (client, engine, server).Limits
unplacedDefensesinstead of guessing. The olddefensive-ledgerview keeps its own labeling, so a defense inside a helper shows the sink's file there (an upstream quirk, unchanged).examples/bad-ish-solid/reports/*.mdgoldens are stale against the current analysis (for example Chart's max depth 9 vs 10). Both repos produce the same current output, so I compared with the live CLI, not the goldens.Survey moves: server: traces +4, outcome partial +4, stops +55 (budget-exhausted +1, external-code +43, untraced +11). The new Python exports in
server/(the Pydantic mirror here,dataflow/signals.pyin #399) enter the survey's hash sample; no analysis code changed.Stack: data-flow reporting
What splits: Bring tsx-data-flow's reporting into srcly (M7): the engine op, then the server and CLI wiring with metrics and marks, then docs and the skill.
Why it splits: The engine op is a self-contained contract that can be checked against the old CLI on its own. The server layer is the user-visible change with screenshots. Docs follow the shipped behavior.
Why this split: I rejected one PR per finding rule: both rules, the metrics and
dataflow.mdall come from one legacy report build, so splitting them would mean three ops that each build it.fileSignalsop, contract and Python mirror.srcly report --dataflow,srcly compare --dataflow, six data-flow metrics, treemap and code-viewer marks.🤖 Generated with Claude Code