Skip to content

feat(dataflow): finish M7 with relay findings, retire tsx-dataflow-integration - #415

Merged
byronwall merged 2 commits into
mainfrom
claude/m7-closeout-retire-093644
Nov 22, 2026
Merged

byronwall merged 2 commits into
mainfrom
claude/m7-closeout-retire-093644

Conversation

@byronwall

Copy link
Copy Markdown
Owner

srcly report --dataflow now reports two more data-flow findings: context-relay and broad-prop-bundle. Each one is a parent that reads a context hook and passes context-like props, or three or more plain props, to a child in the same feature. With this, Milestone 7 is done and the tsx-dataflow-integration plan retires. Its lasting design rules, decisions and measurements are now in docs/dataflow-engine.md.

What you'll see

  • report.md's Data flow section lists the two new rules beside impossible-defense and repeated-fork, and its summary line counts prop relays.
  • The code viewer marks each relay line under Prop Relay.
  • docs/intent/tsx-dataflow-integration/ is gone. docs/initiative-history.json has its closure record. Links into it now point at 4727bd56.

M7 checklist

M7 item State
Engine fileSignals op Done, #398
impossible-defense and repeated-fork findings Done, #398
context-relay and broad-prop-bundle findings This PR. Built from the legacy report's context-relay pass, with no analysis change.
Catalog metrics (impossible defenses, repeated forks, relay, shape changes, path depth, fan-out) Done, #399
dataflow_defensive_ops metric Dropped: the legacy count is per sink, and one guard feeds many sinks, so a sum per file counts a guard many times. The defensive ledger in dataflow.md lists the guards.
Markers from finding spans Done, #399 (routers/files.py:_dataflow_markers)
findings/dataflow.py tool Dropped: findings reach report.md and marks from the saved result. They are not in the file-findings panel.
dataflow.md work packets in srcly report Done, #399
Agent skill merged into skills/srcly-code-quality Done, #400. The new rules are added here.
Compare picks these up Done, #399 (metrics) and #406 (per-function changes)
Start the tier-2 run from the app Not built. Now the backlog task task-start-the-data-flow-batch-run-from-the-app. Today only the CLI starts it.

Proof

On engine/examples/bad-ish-solid after srcly report --dataflow, the treemap colored by Impossible Defenses: DashboardShell.tsx is red with 12, and the other files are 0.

Treemap colored by Impossible Defenses

The code viewer on DashboardShell.tsx with Impossible Defenses picked: it marks lines 12 and 13, and the counter shows 11 marked lines (line 68 holds two guards).

Code viewer marks for Impossible Defenses

srcly report --dataflow --profile frontend on ~/Projects/explorEDA/apps/app (read-only) wrote dataflow.md (1,368 lines of work packets) and this report.md section (trimmed):

## Data flow

The TypeScript checker found 0 type-impossible `??`/`?.` guards, 14 repeated forks and 0 prop relays to same-feature children. Read `dataflow.md` for ranked work packets, ...

| repeated-fork | `src/AddDatabase.tsx:394` | `SourcePicker` tests `mode` at 6 sibling branch sites (lines 394, 395, 453, 466, 482, 559). ...
| repeated-fork | `src/App.tsx:188` | `App` tests `previous.status` at 6 sibling branch sites (lines 188, 200, 267, 284, 292, 308). ...

The new rules on a fixture (engine/test/srcly/__fixtures__/context-relay, test in engine/test/srcly/file-signals.test.ts):

broad-prop-bundle  src/notes/NotesPage.tsx:10  Passes 3 props (`name`, `count`, `owner`) to `NoteHeader` (src/notes/NoteHeader) while this file reads `useWorkspace`. ...
context-relay      src/notes/NotesPage.tsx:11  Relays `workspace`, `settings` to `NoteList` (src/notes/NoteList) while this file reads `useWorkspace`. ...

scripts/check.sh (what CI's build job runs) passes: client 492 tests, engine 748 passed and 9 skipped, server 622 passed, with types and lint. The retirement validator (validate-sleuth.mjs --retirement) passed before the folder was removed. I did not run the Playwright browser suite locally; CI runs it.

Survey moves: none. pnpm survey-gate from 4727bd56 to this head: 557 traces, "No moves", "Survey gate passed".

Where the plan's lasting facts went

  • docs/dataflow-engine.md (new): the shape, the three invariants, session tiers, outcomes and positions, the contract rule, containment, batch evidence and the four rules, the decisions still in force, the dropped items, and the key measurements.
  • docs/dataflow-coverage.md, docs/CODE_MAP.md and AGENTS.md now link to it instead of the plan. AGENTS.md drops the stale "M5's planned analysis edits" line.
  • skills/srcly-code-quality/SKILL.md, site/src/docs/pages/data-flow.md and findings.md describe the four rules.

Limits

  • explorEDA has no impossible defenses and no prop relays, so the colored treemap and the marks are shown on bad-ish-solid.
  • The screenshots come from the app's narrow browser pane (800 × 600).
  • docs/intent/dataflow-robustness/initiative-map.json still says its T24 (the same work as M7) is "not built". That plan is not part of this change, so only its links were fixed.

🤖 Generated with Claude Code

byronwall and others added 2 commits November 21, 2026 23:16
fileSignals turns the legacy report's context-relay pass into two finding
rules. report.md counts them and the code viewer marks them under Prop Relay.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
M7 is complete, so the plan retires. Its design rules, decisions and
measurements move to docs/dataflow-engine.md. The four data-flow finding
rules are in the skill and site. Links into the plan point at 4727bd5. The
in-app tier-2 trigger is a backlog task.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@byronwall
byronwall enabled auto-merge (squash) November 22, 2026 04:31
@byronwall
byronwall merged commit f445fee into main Nov 22, 2026
7 checks passed
@byronwall
byronwall deleted the claude/m7-closeout-retire-093644 branch November 22, 2026 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant