Repository navigation
feat(dataflow): finish M7 with relay findings, retire tsx-dataflow-integration - #415
Merged
Merged
Conversation
fileSignals turns the legacy report's context-relay pass into two finding rules. report.md counts them and the code viewer marks them under Prop Relay. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
M7 is complete, so the plan retires. Its design rules, decisions and measurements move to docs/dataflow-engine.md. The four data-flow finding rules are in the skill and site. Links into the plan point at 4727bd5. The in-app tier-2 trigger is a backlog task. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
srcly report --dataflownow reports two more data-flow findings:context-relayandbroad-prop-bundle. Each one is a parent that reads a context hook and passes context-like props, or three or more plain props, to a child in the same feature. With this, Milestone 7 is done and thetsx-dataflow-integrationplan retires. Its lasting design rules, decisions and measurements are now indocs/dataflow-engine.md.What you'll see
report.md's Data flow section lists the two new rules besideimpossible-defenseandrepeated-fork, and its summary line counts prop relays.docs/intent/tsx-dataflow-integration/is gone.docs/initiative-history.jsonhas its closure record. Links into it now point at4727bd56.M7 checklist
fileSignalsopimpossible-defenseandrepeated-forkfindingscontext-relayandbroad-prop-bundlefindingsdataflow_defensive_opsmetricdataflow.mdlists the guards.routers/files.py:_dataflow_markers)findings/dataflow.pytoolreport.mdand marks from the saved result. They are not in the file-findings panel.dataflow.mdwork packets insrcly reportskills/srcly-code-qualitytask-start-the-data-flow-batch-run-from-the-app. Today only the CLI starts it.Proof
On
engine/examples/bad-ish-solidaftersrcly report --dataflow, the treemap colored by Impossible Defenses:DashboardShell.tsxis red with 12, and the other files are 0.The code viewer on
DashboardShell.tsxwith Impossible Defenses picked: it marks lines 12 and 13, and the counter shows 11 marked lines (line 68 holds two guards).srcly report --dataflow --profile frontendon~/Projects/explorEDA/apps/app(read-only) wrotedataflow.md(1,368 lines of work packets) and thisreport.mdsection (trimmed):The new rules on a fixture (
engine/test/srcly/__fixtures__/context-relay, test inengine/test/srcly/file-signals.test.ts):scripts/check.sh(what CI'sbuildjob runs) passes: client 492 tests, engine 748 passed and 9 skipped, server 622 passed, with types and lint. The retirement validator (validate-sleuth.mjs --retirement) passed before the folder was removed. I did not run the Playwrightbrowsersuite locally; CI runs it.Survey moves: none.
pnpm survey-gatefrom4727bd56to this head: 557 traces, "No moves", "Survey gate passed".Where the plan's lasting facts went
docs/dataflow-engine.md(new): the shape, the three invariants, session tiers, outcomes and positions, the contract rule, containment, batch evidence and the four rules, the decisions still in force, the dropped items, and the key measurements.docs/dataflow-coverage.md,docs/CODE_MAP.mdandAGENTS.mdnow link to it instead of the plan.AGENTS.mddrops the stale "M5's planned analysis edits" line.skills/srcly-code-quality/SKILL.md,site/src/docs/pages/data-flow.mdandfindings.mddescribe the four rules.Limits
bad-ish-solid.docs/intent/dataflow-robustness/initiative-map.jsonstill says its T24 (the same work as M7) is "not built". That plan is not part of this change, so only its links were fixed.🤖 Generated with Claude Code