Skip to content

fix(event): strip spaces around speaker designation and company #664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
harshtandiya merged 1 commit into from
Oct 26, 2026
Merged

fix(event): strip spaces around speaker designation and company #664

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion buzz/www/event/index.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,8 @@ def format_day(date) -> str:


def join_parts(parts: list, separator: str) -> str:
return separator.join([part for part in parts if part])
stripped_parts = [part.strip() for part in parts if part]
return separator.join([part for part in stripped_parts if part])


def format_time_range(start, end) -> str:
Expand Down
6 changes: 5 additions & 1 deletion buzz/www/event/test_event.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
SpeakerProfileFactory,
UserFactory,
)
from buzz.www.event.index import EventPage
from buzz.www.event.index import EventPage, join_parts


class TestEventPage(IntegrationTestCase):
Expand Down Expand Up @@ -75,6 +75,10 @@ def test_schedule_talk_shows_title_and_speakers(self):
self.assertEqual((row["title"], row["speakers"]), ("Scaling apps", "Asha Rao"))
self.assertEqual(context["speakers"][0]["name"], "Asha Rao")

def test_join_parts_strips_spaces_around_each_part(self):
self.assertEqual(join_parts(["Engineer ", " Frappe"], ", "), "Engineer, Frappe")
self.assertEqual(join_parts([" ", "Frappe"], ", "), "Frappe")

def test_time_zone_falls_back_to_system(self):
self.set_event({"time_zone": "", "time_zone_label": ""})
self.assertTrue(EventPage(self.route).timezone_label)
Expand Down
Loading