Repository navigation
fix(event): strip spaces around speaker designation and company - #664
Open
harshtandiya wants to merge 1 commit into
Open
harshtandiya wants to merge 1 commit into
harshtandiya wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018MQsUv1ihpi72S3y3Zg9G9
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Your trial has ended. Reactivate Greptile to resume code reviews.
Contributor
Backend test coverage: 93%Commit 98389fa. Test modules are excluded. Coverage by file
106 empty files skipped. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
join_partsnow strips each part before joining, so speaker roles render asEngineer, Frappeinstead ofEngineer , Frappewhen the designation or company has stray leading or trailing spaces.join_parts.Tests were not run locally (
benchisn't available in this environment); I only checked the join logic directly.Generated by Claude Code