fix: add #[non_exhaustive] to ChannelError, sanitizer errors, SubAgentError#4737
Merged
Conversation
github-actions
Bot
added
bug
This was
linked to
issues
May 30, 2026
bug-ops
force-pushed
the
fix/4716-non-exhaustive-error-enums
branch
from
11556f4 to
bcad6ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Continues the workspace-wide
#[non_exhaustive]cleanup started in PR #4658 (62ccdd4). Without this attribute, adding a new error variant is a semver-breaking change for any downstream crate that matches exhaustively.zeph-core:ChannelError— used by all channel adapters (CLI, Telegram, Discord, Slack); expected to gain new variants as backends expandzeph-sanitizer:QuarantineError,MemoryValidationError,CausalIpiError— three public error enums missing the attributezeph-subagent:SubAgentError— noted alongsideWorktreeError(enhancement(worktree): add #[non_exhaustive] to WorktreeError #4703) as part of the same cleanupNo downstream exhaustive
matcharms exist for any of these enums, so no wildcard_arms needed.Test plan
cargo +nightly fmt --check— cleancargo clippy -p zeph-core -p zeph-sanitizer -p zeph-subagent -- -D warnings— cleanRUSTFLAGS="-D warnings" cargo check -p zeph-core -p zeph-sanitizer -p zeph-subagent --all-targets --locked— cleancargo nextest run -p zeph-core -p zeph-sanitizer -p zeph-subagent --lib --bins— 2222 passed, 2 skippedCloses #4716, #4726, #4732